Optimize ZSTD_wildcopy - #2256
Merged
Merged
Conversation
Contributor
|
Awesome! I'll run my benchmarks and post them here. The failing Travis test seems to be just noise. |
terrelln
reviewed
Jul 28, 2020
Contributor
|
Benchmarks run on
|
Contributor
|
This seems like a merge to me. The only losses are on 32-bit mode and really old compilers. Everything else is neutral (within noise) or a 0-2% gain. Additionally, this code is closer to what we would like the compiler to generate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
memcpyinstead ofCOPY16so that theaddinstruction can be moved after the branch. This could save 1 instruction when compiling with gcc.Codegen before this PR: in Basic Block 1, 4 instructions execute before jmp instruction.
Codegen after this PR: in Basic Block 1, 3 instructions execute before jmp instruction.
