ASTableView crashes with assertion "Node should always be marked invisible before deallocating" depending on header height.

[mikhailmulyar]

Hi. I have simple ASTableNode showing sectioned list. There is a really strange behaviour. App stops with assertion "Node should always be marked invisible before deallocating" in a second after table content shows when reallocing my custom ASCellNode. There is nothing happening at the moment, no updates or reloads.
Most strange thing is that crash depends on tableView header height. If i return 15 in tableView(tableView: UITableView, viewForHeaderInSection section: Int) app runs ok. If i return 18 it crashes. So i guess it is something related to how cells positioned in the view.
Here is the screen at crash state. There is searchBar - 44 height, headers are 18, and cell nodes are 41.
I'm using latest master version.

[hannahmbanana]

@mikhailmulyar: Thanks for reporting this! This issue looks similar to #2205, which @Adlai-Holler is planning on investigating soon.

[Adlai-Holler]

Hi @mikhailmulyar I'm investigating this for you. I've got a couple quick questions:

• Are any of your nodes set with shouldRasterizeDescendants=YES? Any of them layerBacked=YES?
• How are your section headers working? Are you implementing viewForHeaderInSection and returning cellNode.view?
• Which node is hitting the assertion failure? A node for a row, a node for a section, or one of the subnodes?

I know those assertion failures can be extremely irritating so I'll do my best to get this fixed the right way!

[mikhailmulyar]

Hi @Adlai-Holler.

1. I've used shouldRasterizeDescendants in ASCellNode. However when i received bug, i'm pretty sure i've tried to turn it off, and it did not change anything
2. Yes. I'm returning cellNode.view and storing them in array. However it does not matter, since i've completely commented viewForHeaderInSection and only returned height in heightForHeaderInSection. The screenshot is made in that state, as you can see headers are empty, there is nothing at all.
3. Custom subclass of ASCellNode for row.

[Adlai-Holler]

@mikhailmulyar Hi! We've been super busy preparing for the 2.0 launch but this is still an important issue for us.

Curious if there has been any change in behavior from the framework, or have you found a workaround that unblocks you on this issue?

[mikhailmulyar]

Hi @Adlai-Holler. At the moment this issue is not happens with exactly same style. But i have not tested it with exactly same nodes and headers count. I have now a bit different count of elements in sections.
However it still happens in another case. So i have pretty same screen with same height of elements, but with different amount of elements in section. I have 14 elements in total, and 2 last of them out of screen(not visible). Element 13 is like 15-20 pixels away from edge of the screen. When i enter text in search bar, it displays found elements and currently simply does reloadData() when data source updated. So here are the steps to reproduce after table initially loaded

1. Input anything in search for table to reload.
2. Delete search text, so table will reload again and show all elements
3. Input text again, after table reloads again all nodes deallocs and assertion happens for node 13.

If before step 3) ill scroll down to make element visible and then scroll back up, and search, assertion does not happen. Node correctly marked was invisible.
So it seems at reload some of close to edge, but not visible nodes somehow marked as visible, but do not marked back as invisible after that

[mikhailmulyar]

I've checked when didEnterVisibleState called for this node. It has zero frame in that moment.
<MessengerApp.ContactNode: 0x7fe820e306a0; frame = (0 0; 0 0); interfaceState = { MeasureLayout | Preload | Display | Visible }>
I have about 1 week ago version from master at the moment