This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Replace ASButtonState with ASControlState#1038
Merged
appleguy merged 4 commits intofacebookarchive:masterfrom Jan 6, 2016
Merged
Replace ASButtonState with ASControlState#1038appleguy merged 4 commits intofacebookarchive:masterfrom
appleguy merged 4 commits intofacebookarchive:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Contributor
There was a problem hiding this comment.
spelling typo here. should be _selectedAttributedTitle
appleguy
added a commit
that referenced
this pull request
Jan 6, 2016
[ASButtonNode] Use ASControlState instead of declaring a unique ASButtonState type.
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Sep 16, 2020
- The issues in facebookarchive#1038 are not explained. - In `ASCollectionViewTests` do not mock every `collectionViewLayout`, only do it for the test that requires it. In addition, call `-stopMocking` when done. OCMock 3.6 found this code using stuff after it should have been. - 5c42bb4 says the layer tests are not typically run, but they are in the project. That diff refers to ASUIViewTests being skipped, but those tests do not exist. So I've just disabled them in this diff. It is not clear how they ever worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following the UIControl design, removed ASButtonState from ASButtonNode and added ASControlState to ASControlNodes, also added a selectedState to all ASControlNodes.
@appleguy @connor