This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Resolve Internal Inconsistency During Updates When Using Stable Range Controller#1060
Merged
appleguy merged 1 commit intofacebookarchive:masterfrom Jan 14, 2016
Conversation
Contributor
Author
|
Ah I just saw #1054 . This may work as a hotfix. |
Contributor
|
@Adlai-Holler thank you for debugging my regression. I also appreciate you making a minimized change, as this code has actually already been tested (although granted, not with every more recent change). I'll push out a new dot release shortly, probably later tonight. |
appleguy
added a commit
that referenced
this pull request
Jan 14, 2016
Resolve Internal Inconsistency During Updates When Using Stable Range Controller
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #1028 #1055 #1047 .
The issue seems to be caused by one of the changes in ffcddf3 where we stopped checking if the range was valid before removing nodes from the working range. I just reverted that change exactly as-was and the issue is gone for me.
@appleguy I'm not sure the implications of this change. I suspect it means that under certain conditions, nodes won't be removed from the working range. We may now be throwing the baby out with the bathwater.