Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

[ASEditableTextNode] Support scrolling while maintaining workaround for Apple bug when disabling it.#1069

Merged
appleguy merged 1 commit intofacebookarchive:masterfrom
lkzhao:master
Jan 20, 2016
Merged

[ASEditableTextNode] Support scrolling while maintaining workaround for Apple bug when disabling it.#1069
appleguy merged 1 commit intofacebookarchive:masterfrom
lkzhao:master

Conversation

@lkzhao
Copy link
Copy Markdown

@lkzhao lkzhao commented Jan 15, 2016

No description provided.

@facebook-github-bot
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

Comment thread AsyncDisplayKit/ASEditableTextNode.mm Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open bracket on next line - match the other methods. Not a blocker, just FYI :)

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@appleguy
Copy link
Copy Markdown
Contributor

@lkzhao all the details are in #1063 - thank you for raising this bit of ASDK history I'd long forgotten, and bringing this improvement to others!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify the @default value for this

@appleguy appleguy changed the title Allow ASEditableTextNode to scroll [ASEditableTextNode] Support scrolling while maintaining workaround for Apple bug when disabling it. Jan 20, 2016
@appleguy
Copy link
Copy Markdown
Contributor

Go ahead and update the comments in another diff. Maybe you can also rename the method I mentioned in this one - #1078 . Thanks @lkzhao !

appleguy added a commit that referenced this pull request Jan 20, 2016
[ASEditableTextNode] Support scrolling while maintaining workaround for Apple bug when disabling it.
@appleguy appleguy merged commit 3aceabb into facebookarchive:master Jan 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants