Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

[ASTextNode] Optimize handling of constrained size to almost never recreate NSLayoutManager#1100

Merged
appleguy merged 1 commit intomasterfrom
ASTextNodeRendererRefactor
Jan 24, 2016
Merged

[ASTextNode] Optimize handling of constrained size to almost never recreate NSLayoutManager#1100
appleguy merged 1 commit intomasterfrom
ASTextNodeRendererRefactor

Conversation

@appleguy
Copy link
Copy Markdown
Contributor

This also fixes three fairly subtle but serious bugs: #1076, #1046 and #1031.

cc @aaronschubert0 - note I ended up tracing a logic flaw to the most recent patch in this area (#1079), which altered the inset handling with the shadower. I'm still glad you put up this change because it did very clearly appear to improve the behavior, but worsened other situations, like the centering case.

@nvh - you'd be the most valuable tester, although I confirmed both types of clipping miscalculations very strategically recreated in your awesome sample app appear fully corrected.

@yxztj - I actually was using your sample app for the majority of the time it took me to carefully understand and adjust this code.

@bsmith11, @timominous, @AttilaTheFun, @nguyenhuy, @1nput0utput, @stowy, @lappp9, @RCacheaux, @samhsiung, @binl, @rcancro - Please join us in testing!

I'm excited that I feel confident working in this part of the codebase; it's probably one of the few scary corners remaining to be confronted. One of the primary needs now is a big expansion in automated performance and logic testing...

The overall code quality and engineering style in the framework, to me, feels awesome. I'm glad to be working on continuing to do industry-first things as a community together!

…create NSLayoutManager

This also fixes two fairly subtle but serious bugs, #1076 and #1046.
@appleguy appleguy added this to the 1.9.6 milestone Jan 24, 2016
appleguy added a commit that referenced this pull request Jan 24, 2016
[ASTextNode] Optimize handling of constrained size to almost never recreate NSLayoutManager
@appleguy appleguy merged commit 344b3a4 into master Jan 24, 2016
@appleguy appleguy deleted the ASTextNodeRendererRefactor branch January 24, 2016 09:41
@aaronschubert0
Copy link
Copy Markdown
Contributor

Awesome work @appleguy thanks for putting in the effort to make this area of ASDK so solid!

@nvh
Copy link
Copy Markdown
Contributor

nvh commented Jan 25, 2016

@appleguy Thanks for looking into this! Most of the bugs, especially those with the centering are fixed in my original use cases. With the firstHeadlineIndent there still is a problem with clipping text on a single line. I've updated my test project to display this behaviour.

simulator screen shot 25 jan 2016 13 43 25

Should I open a new issue for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants