This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Conversation
appleguy
added a commit
that referenced
this pull request
Jan 24, 2016
[ASTextNode] Optimize handling of constrained size to almost never recreate NSLayoutManager
Contributor
|
Awesome work @appleguy thanks for putting in the effort to make this area of ASDK so solid! |
Contributor
|
@appleguy Thanks for looking into this! Most of the bugs, especially those with the centering are fixed in my original use cases. With the firstHeadlineIndent there still is a problem with clipping text on a single line. I've updated my test project to display this behaviour. Should I open a new issue for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This also fixes three fairly subtle but serious bugs: #1076, #1046 and #1031.
cc @aaronschubert0 - note I ended up tracing a logic flaw to the most recent patch in this area (#1079), which altered the inset handling with the shadower. I'm still glad you put up this change because it did very clearly appear to improve the behavior, but worsened other situations, like the centering case.
@nvh - you'd be the most valuable tester, although I confirmed both types of clipping miscalculations very strategically recreated in your awesome sample app appear fully corrected.
@yxztj - I actually was using your sample app for the majority of the time it took me to carefully understand and adjust this code.
@bsmith11, @timominous, @AttilaTheFun, @nguyenhuy, @1nput0utput, @stowy, @lappp9, @RCacheaux, @samhsiung, @binl, @rcancro - Please join us in testing!
I'm excited that I feel confident working in this part of the codebase; it's probably one of the few scary corners remaining to be confronted. One of the primary needs now is a big expansion in automated performance and logic testing...
The overall code quality and engineering style in the framework, to me, feels awesome. I'm glad to be working on continuing to do industry-first things as a community together!