This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASVideoNode] Performance enhancements#1106
Merged
appleguy merged 5 commits intofacebookarchive:masterfrom Jan 25, 2016
Merged
Conversation
Contributor
There was a problem hiding this comment.
if _shouldBePlaying is already set, we should not need to set it?! :) @lappp9
Contributor
Author
There was a problem hiding this comment.
Ah yeah, @appleguy this is a weird thing i need to change but didn't want to until i had time to put a test or two around the logic. I reset it to _shouldBePlaying because a call to -pause sets shouldBePlaying to NO. Probably a side effect i need to get rid of, but I was originally trying to cut down on duplication of setting that property, lol
appleguy
added a commit
that referenced
this pull request
Jan 25, 2016
[ASVideoNode] Performance enhancements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Asynchronously loads first frame as a placeholder when video doesn't need to be playing
• Removed extra pauses that caused some slow down.