This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[Layout] Add extensibility support to ASLayoutableStyle#2294
Closed
maicki wants to merge 6 commits intofacebookarchive:masterfrom
maicki:ASLayoutableStyleExtensibility
Closed
[Layout] Add extensibility support to ASLayoutableStyle#2294maicki wants to merge 6 commits intofacebookarchive:masterfrom maicki:ASLayoutableStyleExtensibility
maicki wants to merge 6 commits intofacebookarchive:masterfrom
maicki:ASLayoutableStyleExtensibility
Conversation
ghost
added
the
maicki
changed the title
maicki
changed the title
Contributor
|
test this please |
Contributor
Author
|
As a lot of work went into the layout infrastructure that will cause merge conflicts as well as further investigation for this kind of extensibility needs to happen, let's close this PR. |
This was referenced Jan 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of
ASLayoutableStylethat combines all style related properties for aASLayoutElementwe need to provide some kind of extensibility support. This is important as it should be possible to add custom layout specs and extend theASLayoutableStylefor usage within the custom layout specs.The general idea is outline in this gist via examples: https://gist.github.com/maicki/2630b51f62cbedc0cb34e0bcac96d6c9