This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASVideoPlayerNode] Added an optional full screen button#2688
Merged
Adlai-Holler merged 11 commits intofacebookarchive:masterfrom Dec 21, 2016
MarvinNazari:master
Merged
[ASVideoPlayerNode] Added an optional full screen button#2688Adlai-Holler merged 11 commits intofacebookarchive:masterfrom MarvinNazari:master
Adlai-Holler merged 11 commits intofacebookarchive:masterfrom
MarvinNazari:master
Conversation
…duration time label didn't updated correctly
Adlai-Holler
approved these changes
Dec 21, 2016
Contributor
Adlai-Holler
left a comment
There was a problem hiding this comment.
@MarvinNazari Thanks for adding this! Video player node is becoming very fleshed-out, and just in time since top-notch video support is highly sought-after by users this year.
Contributor
Author
|
@Adlai-Holler Happy to contribute, even with my limited Objective-C skills 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enable the new control type
ASVideoPlayerNodeControlTypeFullScreenButtonyou need replace the default default controls.and even return an image for the button