Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

[AS{Overlay,Background}LayoutSpec] Assert when attempting to set a nil background / overlay layout element.#2796

Merged
Adlai-Holler merged 1 commit intofacebookarchive:masterfrom
master-nevi:dr/add-assertions-to-background-overlay-layout-elements
Dec 19, 2016
Merged

[AS{Overlay,Background}LayoutSpec] Assert when attempting to set a nil background / overlay layout element.#2796
Adlai-Holler merged 1 commit intofacebookarchive:masterfrom
master-nevi:dr/add-assertions-to-background-overlay-layout-elements

Conversation

@master-nevi
Copy link
Copy Markdown
Contributor

@master-nevi master-nevi commented Dec 19, 2016

Addresses #2795 (comment)

Add assertions here to reenforce the non-nullability of the background and overlay layout elements.

cc @maicki

@master-nevi master-nevi changed the title Assert when attempting to set a nil background / overlay layout element. [AS{Overlay,Background}LayoutSpec] Assert when attempting to set a nil background / overlay layout element. Dec 19, 2016
Copy link
Copy Markdown
Contributor

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom!

@Adlai-Holler Adlai-Holler merged commit 498e5a9 into facebookarchive:master Dec 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants