This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Add locking around setting weakCacheEntry ivar#2812
Merged
Adlai-Holler merged 1 commit intofacebookarchive:masterfrom Dec 21, 2016
Merged
Add locking around setting weakCacheEntry ivar#2812Adlai-Holler merged 1 commit intofacebookarchive:masterfrom
Adlai-Holler merged 1 commit intofacebookarchive:masterfrom
Conversation
nguyenhuy
suggested changes
Dec 20, 2016
|
|
||
| _weakCacheEntry = nil; // release contents from the cache. | ||
| __instanceLock__.lock(); | ||
| _weakCacheEntry = entry; // Retain so that the entry remains in the weak cache |
Contributor
There was a problem hiding this comment.
This should be set to nil?
chrisdanford
force-pushed
the
fix_weak_cache_entry_locking
branch
3 times, most recently
from
7287cf2 to
9edbed1
Compare
chrisdanford
force-pushed
the
fix_weak_cache_entry_locking
branch
from
9edbed1 to
42879dd
Compare
nguyenhuy
approved these changes
Dec 20, 2016
nguyenhuy
reviewed
Dec 20, 2016
|
|
||
| - (void)clearContents | ||
| { | ||
| [super clearContents]; |
Contributor
There was a problem hiding this comment.
Thanks for fixing the indentation as well!
Contributor
|
Nice @chrisdanford! Safety dance! It seems like the CI failure is flaky – opened #2818. Jenkins test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointed out by @nguyenhuy. There was no locking around this non-atomic ivar.