This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Remove Irritating Layout Attributes Assertions#2828
Merged
Adlai-Holler merged 1 commit intomasterfrom Dec 25, 2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When these fire on the CI, nothing is shown in the log message and it just silently fails. That's super annoying. Obviously I feel bad just removing them but the call patterns around these methods vary so much from iOS version to iOS version – as Apple continuously retools UICollectionView – so chasing a guarantee this strict right now isn't worth our time.