Support Buck build#2849
Conversation
|
Here are screenshots of 2 consecutive test passes ( |
Adlai-Holler
left a comment
There was a problem hiding this comment.
I don't know much about Buck but this looks beautiful! Faster builds and more smarter build system = 👍I support landing this whenever you feel it appropriate.
I would be good if possible to separate out the Buck support from the ASVideoNode delegate change, no?
- Weak linking Photos and MapKit. - Revisit //:Tests' list.
|
@Adlai-Holler: Thanks for the review. The ASVideoNode delegate change was merged in #2844. I've rebased this PR to remove that commit. Let's wait for another day so others have a chance to raise any questions/concerns. Also, I can't land this myself (no GitHub permission) :) |
|
👍 |
|
Here we go! |
|
Very excited. Thanks! |




First attempt to support Buck 🐇 🏎 💨
How to use:
Dependency resolution:
pod 'PINRemoteImage/iOS', ' 3.0.0-beta.7'andpod 'PINRemoteImage/PINCache'in Podfile), or only lives in our repo (in case of FBSnapshotTestCase, OCMock, etc).Remaining/followed-up tasks:
This PR depends on #2844.
Let me know if you have any questions or suggestions!