This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Remove Unused Implementations of moveItem: and moveSection:#2863
Merged
Adlai-Holler merged 1 commit intomasterfrom Jan 4, 2017
Merged
Remove Unused Implementations of moveItem: and moveSection:#2863Adlai-Holler merged 1 commit intomasterfrom
Adlai-Holler merged 1 commit intomasterfrom
Conversation
Contributor
Author
|
Since this doesn't affect behavior at all, I'll land once CI passes. |
|
I was going to ask whether these methods are deprecated. Thanks for the PR to clarify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since moves are composite operations (like
reloadItemsandreloadSections), they must be handled byASChangeSetDataControllerand they are. TheASDataController-level implementations are completely unused and don't fit into the current architectural model for the two classes. In preparation for #698, which we'll hopefully implement soon, we should remove this code to reduce confusion and complexity.