This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASImageNode] Copy ASTextNode’s implementation of placeholderImage into ASImageNode in order to fix usage of ASImageNode.placeholderColor (#2865)#2866
Merged
Adlai-Holler merged 1 commit intofacebookarchive:masterfrom Jan 5, 2017
Conversation
… in order to fix the usage of placeholderColor.
master-nevi
changed the title
master-nevi
changed the title
master-nevi
changed the title
Adlai-Holler
approved these changes
Jan 5, 2017
Contributor
Adlai-Holler
left a comment
Adlai-Holler
left a comment
There was a problem hiding this comment.
Wow this is fascinating! The placeholder system was added in bf01b07 in 2014, and ASImageNode.placeholderColor was never ever used in any way! Glad to see this code finally made it into the framework.
In the future, we could elevate the placeholderColor into ASDisplayNode and provide this as a default implementation of placeholderImage.
Contributor
|
Thanks @master-nevi |
Contributor
Author
|
@Adlai-Holler you're very welcome. Glad I could contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation copied from ASTextNode: https://github.com/facebook/AsyncDisplayKit/blob/f637392a770ae193c41b7aadd9a01b49b335d9d3/AsyncDisplayKit/ASTextNode.mm#L849
Addresses: #2865
Also updates the
Kittensample project to demonstrate theplaceholderColor/placeholderFadeDurationAPIs.