[ASCellNode] "selectedBackgroundView" property #2875
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
changed the title
Adlai-Holler
left a comment
Adlai-Holler
left a comment
There was a problem hiding this comment.
Thanks for opening this diff @acedened ! One comment before we land.
| cell.node = node; | ||
| cell.backgroundColor = node.backgroundColor; | ||
| cell.selectionStyle = node.selectionStyle; | ||
| cell.selectedBackgroundView = node.selectedBackgroundView; |
There was a problem hiding this comment.
Would you be willing to add the same code into -[ASCollectionView collectionView:cellForItemAtIndexPath:]?
|
Jenkins, test this please |
Adlai-Holler
left a comment
Adlai-Holler
left a comment
There was a problem hiding this comment.
@acedened Looks like we need a rebase/merge. The passthrough properties like selectionStyle got moved into a separate section, and this should go in there as well.
|
@Adlai-Holler Done. |
|
Jenkins add to whitelist and test this please. |
Adlai-Holler
left a comment
Adlai-Holler
left a comment
There was a problem hiding this comment.
Hmmmm (+2,794, -854) is a lot! There may be an error in your rebase.
ghost
reopened this
|
Fixed! |
Adlai-Holler
left a comment
Adlai-Holler
left a comment
There was a problem hiding this comment.
Nice! Thanks @acedened
2 participants
Just a simple little propetry