Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Pin Collection cellNode.frame = contentView.bounds#2884

Merged
Adlai-Holler merged 1 commit intomasterfrom
AHKeepCollectionCellNodeInCell
Jan 11, 2017
Merged

Pin Collection cellNode.frame = contentView.bounds#2884
Adlai-Holler merged 1 commit intomasterfrom
AHKeepCollectionCellNodeInCell

Conversation

@Adlai-Holler
Copy link
Copy Markdown
Contributor

@Adlai-Holler Adlai-Holler commented Jan 10, 2017

Resolves #2659

Doing the same thing for _ASTableViewCell is actually pretty complex because we have a separate architecture for handling content view size changes. This is at least a step forward.

Copy link
Copy Markdown
Contributor

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Adlai-Holler Adlai-Holler merged commit 98a95a6 into master Jan 11, 2017
hannahmbanana pushed a commit that referenced this pull request Jan 17, 2017
This reverts commit 98a95a6.

Temporary revert to get the branch through testing.
@Adlai-Holler Adlai-Holler deleted the AHKeepCollectionCellNodeInCell branch January 20, 2017 01:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants