This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[Nitpick] Update CocoaPod badges to be dynamic.#2886
Merged
Adlai-Holler merged 1 commit intofacebookarchive:masterfrom Jan 11, 2017
Merged
[Nitpick] Update CocoaPod badges to be dynamic.#2886Adlai-Holler merged 1 commit intofacebookarchive:masterfrom
Adlai-Holler merged 1 commit intofacebookarchive:masterfrom
Conversation
This updates the values automatically, which is perfect to reflect the growth of ASDK. I've wanted to do this for ages but the shield.io API didn't have the support up till now. We lose some granularity but I think this is worth it.
nguyenhuy
approved these changes
Jan 11, 2017
Contributor
nguyenhuy
left a comment
nguyenhuy
left a comment
There was a problem hiding this comment.
Looks great to me. Thanks for working on this, @aaronschubert0.
I'm wondering if these badges to http://asyncdisplaykit.org/ index or showcase pages?
Contributor
|
Huy you raised a good point about the badges being links. Without derailing that, I'm going to land this because it's so good! |
Contributor
Author
|
Awesome thanks guys! @Adlai-Holler @nguyenhuy |
Contributor
|
@aaronschubert0 - this is super awesome! thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the values automatically, which is perfect to reflect the growth of ASDK. I've wanted to do this for ages but the shield.io API didn't have the support up till now. We lose some granularity but I think this is worth it.
Maybe @hannahmbanana or @nguyenhuy could take a quick look. Sorry it's been a while since I've kept up to date with the project, not sure if @appleguy is still directly involved.