This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Use Native convertRect:, convertPoint: Methods to Handle Nil Cases#2889
Merged
Adlai-Holler merged 3 commits intomasterfrom Jan 11, 2017
Merged
Use Native convertRect:, convertPoint: Methods to Handle Nil Cases#2889Adlai-Holler merged 3 commits intomasterfrom
Adlai-Holler merged 3 commits intomasterfrom
Conversation
Contributor
|
I'm not positive this is an issue, but CALayer and UIView document different behavior when the view / layer is nil. CALayer: UIView: |
Contributor
Author
|
@garrettmoon It's true the behavior changes, but I think it's reasonable for us to do the layer-thing for layer-backed nodes, and the view-thing for view-backed nodes. |
05e2848 to
2f85ccd
Compare
garrettmoon
approved these changes
Jan 11, 2017
Contributor
garrettmoon
left a comment
There was a problem hiding this comment.
One final comment: could you add documentation to these methods which says it mirror's UIView's behavior and not CALayer's?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2888 @hannahmbanana
I didn't know this, but
convertPoint:toLayer:nilbehaves a lot differently fromconvertPoint:toView:niland so it's important that we call the appropriate method for the appropriate case.