Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

[UIImage+ASConvenience] as_resizableRoundedImage border doesn't respect roundedCorner argument#2905

Merged
Adlai-Holler merged 3 commits intomasterfrom
HTImageHelperFix
Jan 18, 2017
Merged

[UIImage+ASConvenience] as_resizableRoundedImage border doesn't respect roundedCorner argument#2905
Adlai-Holler merged 3 commits intomasterfrom
HTImageHelperFix

Conversation

@hannahmbanana
Copy link
Copy Markdown
Contributor

@hannahmbanana hannahmbanana commented Jan 18, 2017

Resolves #2903.

#Incorrect:
screen shot 2017-01-17 at 4 03 45 pm

Corrected:
screen shot 2017-01-17 at 4 01 28 pm

@Adlai-Holler
Copy link
Copy Markdown
Contributor

This PR looks awesome but what the heck @ test failure! No description of what failed, and it says the failure is expected. We should probably open the diagnostic log at ~/Library/Developer/Xcode/DerivedData/AsyncDisplayKit-ggogwdgiwffyeianyojvlczlsubz/Logs/Test/4B292CFF-4A82-41D7-ADB6-2775AEE920FA/Session-AsyncDisplayKitTests-2017-01-17_163504-lW4cbr.log and see what's up.

@hannahmbanana
Copy link
Copy Markdown
Contributor Author

@Adlai-Holler - restarting this build didn't seem to help. Do you think pushing an update would cause a different outcome?

@Adlai-Holler
Copy link
Copy Markdown
Contributor

@hannahmbanana Give it a try!

@Adlai-Holler
Copy link
Copy Markdown
Contributor

Well… freaky. Merging!

@Adlai-Holler Adlai-Holler merged commit d41ef55 into master Jan 18, 2017
@Adlai-Holler Adlai-Holler deleted the HTImageHelperFix branch January 18, 2017 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants