This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Fix Test Failures Caused by Pollution Between Test Cases#2935
Merged
Adlai-Holler merged 1 commit intomasterfrom Jan 25, 2017
Merged
Fix Test Failures Caused by Pollution Between Test Cases#2935Adlai-Holler merged 1 commit intomasterfrom
Adlai-Holler merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our collection view is not exception-safe, and this was increased by #2923 . In our collection view tests, windows pile up because the system retains them (animation delegates etc.), and when the device is rotated during some tests, the collection views that were killed by intentional exceptions in prior tests crash.
I tried waiting for the windows to die on their own – by a couple different methods – but no dice. This suffices to fix it.