This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[Layout] Improve Layout System Abstraction#2938
Closed
maicki wants to merge 18 commits intofacebookarchive:masterfrom
maicki:MSImproveLayoutAbstraction
Closed
[Layout] Improve Layout System Abstraction#2938maicki wants to merge 18 commits intofacebookarchive:masterfrom maicki:MSImproveLayoutAbstraction
maicki wants to merge 18 commits intofacebookarchive:masterfrom
maicki:MSImproveLayoutAbstraction
Conversation
…yNode and ASLayoutSpec
…ing in ASDK Layout
maicki
commented
Jan 27, 2017
|
|
||
| if (CGPointEqualToPoint(self.layoutPosition, defaultState.layoutPosition) == NO) { | ||
| [result addObject:@{ @"layoutPosition" : [NSValue valueWithCGPoint:self.layoutPosition] }]; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This needs to be reenabled.
Contributor
Author
|
Replaced by #2941 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our layout system is pretty coupled to the overall ASDK system. This PR is the first step to loosen up this coupling.
For now it:
ASLayoutElement.ASEnvironmentand introduces trait collection support that would allow us to more easier compile out in certain cases.ASLayoutElementStyleExtensionsout fromASEnvironmentTODO:
ASLayoutElementTraitCollectionrelated code toASTraitCollection_extensionsASLayoutElementASEnvironmentTraitCollectionas deprecated