This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Improve Our Handling of Flow Layout Headers/Footers#2939
Merged
Adlai-Holler merged 8 commits intomasterfrom Jan 27, 2017
Merged
Improve Our Handling of Flow Layout Headers/Footers#2939Adlai-Holler merged 8 commits intomasterfrom
Adlai-Holler merged 8 commits intomasterfrom
Conversation
added 2 commits
January 27, 2017 15:32
maicki
approved these changes
Jan 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is valuable in general, and critical for our support for flow layout headers/footers under IGListKit.
Before this diff:
referenceSizeForHeader{ 320, 100 }, the layout will make the header 100 tall.{ {320, 0}, {320, 100} }when measuring.insetForSectionAtIndex:does nothing. It doesn't do nothing! Flow layout calls this directly and uses it to layout items.After this diff:
ASColllectionViewwill intercept thereferenceSizeForHeadercall, and return the calculated size for the header node, so they always match up.referenceSizeForHeaderInSection:to get an exact size constraint for the header.referenceSizeRangeForHeaderwhich is preferred, so the client doesn't have to know the exact header size.ASSizeRangeZeroandASSizeRangeUnconstrainedconstants.