This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASLayoutSpec] Remove legacy and unused parent property#2987
Merged
Adlai-Holler merged 1 commit intofacebookarchive:masterfrom Feb 7, 2017
maicki:MSRemoveLegacyParentPointer
Merged
[ASLayoutSpec] Remove legacy and unused parent property#2987Adlai-Holler merged 1 commit intofacebookarchive:masterfrom maicki:MSRemoveLegacyParentPointer
Adlai-Holler merged 1 commit intofacebookarchive:masterfrom
maicki:MSRemoveLegacyParentPointer
Conversation
nguyenhuy
approved these changes
Feb 6, 2017
garrettmoon
reviewed
Feb 6, 2017
|
|
||
| /** | ||
| * Parent of the layout spec | ||
| */ |
Contributor
There was a problem hiding this comment.
Does this need to be deprecated?
Contributor
Author
There was a problem hiding this comment.
It was never used outside of the framework (and actually in the framework it was not used either if you want to be precise). You can argue it was publicly available, but there was no reason to use it in the first place.
Contributor
There was a problem hiding this comment.
Ok, it's pretty unlikely anyone was using this.
Adlai-Holler
approved these changes
Feb 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.