This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Allow UICollectionViewLayout to Provide Layout Inspector, Always Update Delegate#3003
Merged
Adlai-Holler merged 5 commits intomasterfrom Feb 9, 2017
Merged
Allow UICollectionViewLayout to Provide Layout Inspector, Always Update Delegate#3003Adlai-Holler merged 5 commits intomasterfrom
Adlai-Holler merged 5 commits intomasterfrom
Conversation
…ll the didChangeDelegate/didChangeDataSource on binding
garrettmoon
approved these changes
Feb 9, 2017
Contributor
garrettmoon
left a comment
garrettmoon
left a comment
There was a problem hiding this comment.
This looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3002 and #2634
Before you say it, I know we should protocolize this. We will. But at this stage I don't want to go halfway and do that. This change is intentionally very small so we can get it deployed immediately.
asdk_isFlowLayoutwithasdk_layoutInspectordidChangeCollectionViewDelegate/didChangeCollectionViewDataSourcewhen the layout inspector is bound, so they don't have to call it on themselves.collectionViewargument from the layout inspector initializer because we don't need it anymore.