This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Relayout table view cell nodes if there is a mismatch between content view size and the node's constrained size#655
Merged
appleguy merged 2 commits intofacebookarchive:masterfrom Sep 16, 2015
Conversation
Contributor
nguyenhuy
commented
Sep 15, 2015
nguyenhuy
commented
- Above is the generic case. Correctly handling it means relayout when the table view enters or leaves editing mode is taken care of as well.
- Async data source API removal: In a table view, cell nodes should always fill its content view and table view widths. Thus async data source can no longer provide custom constrained size for cell nodes. This removal allows table view to better handle relayout.
- Some more tests are added to ASTableViewTests to check against use cases handled in this diff.
Contributor
Author
|
With this, I'm confident that #512 is finally solved. |
nguyenhuy
force-pushed
the
relayout_editing_mode
branch
from
748bbe1 to
39f4e3d
Compare
… view size and the node's constrained size - Above is the generic case. Correctly handling it means relayout when the table view enters or leaves editing mode is solved as well. - Async data source API removal: In a table view, cell nodes should always fill its content view and table view widths. Thus async data source can no longer provide custom constrained size for cell nodes. This removal allows table view to better handle relayout. - Some more tests are added to ASTableViewTests to check against use cases handled in this diff.
nguyenhuy
force-pushed
the
relayout_editing_mode
branch
from
39f4e3d to
2d575fc
Compare
Contributor
There was a problem hiding this comment.
I wonder, should we actually be calling didTransitionToState: before the layout has been completed? Maybe we should add a call to -layoutIfNeeded here.
…other state Relayout will be triggered in layoutSubviews (if needed).
nguyenhuy
force-pushed
the
relayout_editing_mode
branch
from
0b9981e to
094d257
Compare
appleguy
added a commit
that referenced
this pull request
Sep 16, 2015
Relayout table view cell nodes if there is a mismatch between content view size and the node's constrained size
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Jan 9, 2018
Fix `ASBackgroundLayoutSpec ` example code bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.