This repository was archived by the owner on Feb 2, 2023. It is now read-only.
fix overflow issues with ASEditableTextNode's textView#935
Merged
appleguy merged 1 commit intofacebookarchive:masterfrom Dec 13, 2015
Merged
fix overflow issues with ASEditableTextNode's textView#935appleguy merged 1 commit intofacebookarchive:masterfrom
appleguy merged 1 commit intofacebookarchive:masterfrom
Conversation
samhsiung
changed the title
appleguy
added a commit
that referenced
this pull request
Dec 13, 2015
Re-enable clipsToBounds on ASEditableTextNode's textView to fix iOS 9 style overflowing
Contributor
|
Thanks a lot for investigating this, @samhsiung!! |
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Jul 21, 2018
* fix SIMULATE_WEB_RESPONSE not imported facebookarchive#449 * Fix to make rangeMode update in right time * remove uncessary assert * textnode2-snapshot-test * add change log * fix image recording * disable recording * renaming test method * reset experiment in teardown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting clipBounds = NO causes UITextView to overflow in iOS9 (works fine however in iOS8), so we fix by removing this config.
Addressing the deleted comment:
before:
after: (more than three lines, the extra lines are clipped)
This should also fix the placeholder text overflowing which has been reported by @steveram