This repository was archived by the owner on Jun 12, 2018. It is now read-only.
Adding mongoproto.OpDelete and mongoproto.OpUpdate to cmd/pcap_converter#42
Merged
tredman merged 2 commits intofacebookarchive:masterfrom Nov 22, 2016
timvaillancourt:pcap_converter_update_delete
Merged
Adding mongoproto.OpDelete and mongoproto.OpUpdate to cmd/pcap_converter#42tredman merged 2 commits intofacebookarchive:masterfrom timvaillancourt:pcap_converter_update_delete
tredman merged 2 commits intofacebookarchive:masterfrom
timvaillancourt:pcap_converter_update_delete
Conversation
…upported in tmc/mongoproto
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding mongoproto.OpDelete and mongoproto.OpUpdate to 'pcap_converter' now that they're supported in tmc/mongoproto after this PR was merged: tmc/mongoproto#2.
This resolves 2 of 3 missing ops in #40, so I will close #40 if this is merged and open a getmore-specific issue for the final missing op.
Example update op:
Example delete (remove) op:
Any thoughts/suggestions appreciated!