Skip to content
This repository was archived by the owner on Jun 12, 2018. It is now read-only.

Adding mongoproto.OpDelete and mongoproto.OpUpdate to cmd/pcap_converter#42

Merged
tredman merged 2 commits intofacebookarchive:masterfrom
timvaillancourt:pcap_converter_update_delete
Nov 22, 2016
Merged

Adding mongoproto.OpDelete and mongoproto.OpUpdate to cmd/pcap_converter#42
tredman merged 2 commits intofacebookarchive:masterfrom
timvaillancourt:pcap_converter_update_delete

Conversation

@timvaillancourt
Copy link
Copy Markdown
Contributor

@timvaillancourt timvaillancourt commented Nov 20, 2016

Adding mongoproto.OpDelete and mongoproto.OpUpdate to 'pcap_converter' now that they're supported in tmc/mongoproto after this PR was merged: tmc/mongoproto#2.

This resolves 2 of 3 missing ops in #40, so I will close #40 if this is merged and open a getmore-specific issue for the final missing op.

Example update op:

$ bsondump flashback.bson 2>/dev/null | grep \"op\":\"update\" | head -1
{"ns":"test.lag_check","ts":{"$date":"2016-10-14T19:02:19.400Z"},"op":"update","query":{"_id":1},"updateobj":{"_id":1,"x":1}}

Example delete (remove) op:

$ bsondump flashback.bson 2>/dev/null | grep \"op\":\"remove\" | head -1
{"ns":"test.items","ts":{"$date":"2016-10-14T19:03:38.380Z"},"op":"remove","query":{"_id":{"$oid":"58012bb839f7e32dab46b8ae"}}}

Any thoughts/suggestions appreciated!

@timvaillancourt timvaillancourt changed the title Adding mongoproto.OpDelete and mongoproto.OpUpdate Adding mongoproto.OpDelete and mongoproto.OpUpdate to cmd/pcap_converter Nov 20, 2016
@tredman
Copy link
Copy Markdown
Contributor

tredman commented Nov 22, 2016

Thanks!

@tredman tredman merged commit 66a671d into facebookarchive:master Nov 22, 2016
@timvaillancourt timvaillancourt deleted the pcap_converter_update_delete branch November 23, 2016 00:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pcap_converter: add mongoproto.OpDelete, mongoproto.OpUpdate and mongoproto.OpGetMore operations once available

2 participants