Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Feature - User Follows#88

Merged
heatonjb merged 1 commit intofacebookarchive:masterfrom
cmlh:user_follows
Aug 5, 2014
Merged

Feature - User Follows#88
heatonjb merged 1 commit intofacebookarchive:masterfrom
cmlh:user_follows

Conversation

@cmlh
Copy link
Copy Markdown
Contributor

@cmlh cmlh commented Jul 15, 2014

In response to the questions related to pagination on "Stack Overflow", etc I have implemented get_users_follows with pagination in the sample web application.

The User ID is @Instagram, i.e. 25025320, but can be changed if required?

Output from the test harness is quoted below:

python-instagram cmlh$ python tests.py 
.........................
----------------------------------------------------------------------
Ran 25 tests in 0.324s

OK
python-instagram cmlh$

I have registered christian.heinrich@cmlh.id.au for the Contributor License Agreement (CLA)

heatonjb added a commit that referenced this pull request Aug 5, 2014
@heatonjb heatonjb merged commit d932162 into facebookarchive:master Aug 5, 2014
@cmlh
Copy link
Copy Markdown
Contributor Author

cmlh commented Aug 6, 2014

Thanks @heatonjb

I am not sure if Instagram/Facebook also want a Pull Request for who the user followed too or if its inclusion would be confusing, as it is a duplication of code and therefore overkill in the sample web application. Please let me know?

@heatonjb
Copy link
Copy Markdown
Contributor

heatonjb commented Aug 6, 2014

This is an open source project, what do you think @cmlh ? Would you find it useful? Anyone else?

@cmlh
Copy link
Copy Markdown
Contributor Author

cmlh commented Aug 7, 2014

@heatonjb,

The change is to replace "user_follows" with "user_followed_by" within d932162

I'll submit another Pull Request from a new git remote branch if no one volunteers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants