Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Create valid path if no api.format specified#89

Merged
heatonjb merged 1 commit intofacebookarchive:masterfrom
tomdottom:master
Aug 5, 2014
Merged

Create valid path if no api.format specified#89
heatonjb merged 1 commit intofacebookarchive:masterfrom
tomdottom:master

Conversation

@tomdottom
Copy link
Copy Markdown
Contributor

Instagrams

/media/shortcode/{shortcode}

endpoint does not currently respond to requests which include a requested return format, ie

/media/shortcode/D.json

and thus leave the api.media_shortcode(shortcode) permanently broken as the _build_path() will always append a trailing "."

/media/shortcode/D.

is also invalid.

Code change removes trailing "." if api.format = '' allowing the following valid request to be made

/media/shortcode/D

Is it really necessary to specify a format as instagrams own docs state endpoint responses are returned as json

@facebook-github-bot
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

heatonjb added a commit that referenced this pull request Aug 5, 2014
Create valid path if no api.format specified
@heatonjb heatonjb merged commit d5730dc into facebookarchive:master Aug 5, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants