This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Show error instead of boolean in exception & add signed header to subscriptions#92
Merged
heatonjb merged 2 commits intofacebookarchive:masterfrom Aug 5, 2014
Merged
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Contributor
Author
|
I made another update which adds the signature to the header when making modifications to subscriptions. These API methods are not listed in the list which requires the signed header but they did require it when I usedthem. |
thelinuxkid
changed the title
heatonjb
added a commit
that referenced
this pull request
Aug 5, 2014
Show error instead of boolean in exception & add signed header to subscriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting True, True, True instead of the values for error code, type and message. I assume we want the important information instead of testing for the keys existence.