Skip to content

Fix scope context not working#63

Merged
facelessuser merged 2 commits intofacelessuser:masterfrom
jfcherng-sublime:fix/scope-context-backtrace
Feb 28, 2022
Merged

Fix scope context not working#63
facelessuser merged 2 commits intofacelessuser:masterfrom
jfcherng-sublime:fix/scope-context-backtrace

Conversation

@jfcherng
Copy link
Copy Markdown
Contributor

@jfcherng jfcherng commented Feb 28, 2022

Fixes 7d789b2#r67624449 and some minor changes for display path like the built-in popup.

  • Remove leading Packages/ and file extension from display paths
  • Italic context name for anonymous contexts

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
- Remove leading "Packages/" and file extension in display path
- Italic context name for anonymous contexts

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: source Related to source code. labels Feb 28, 2022
@facelessuser
Copy link
Copy Markdown
Owner

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Feb 28, 2022
@facelessuser facelessuser merged commit 93cfabd into facelessuser:master Feb 28, 2022
@jfcherng jfcherng deleted the fix/scope-context-backtrace branch February 28, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: source Related to source code. S: approved The pull request is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants