Skip to content

Conversation

@pkess
Copy link

@pkess pkess commented Nov 18, 2024

Replace error message and abort action in csv import plugin with a question for the user how to proceed

@pkess
Copy link
Author

pkess commented Nov 18, 2024

Looks like i based my work on an outdated fork. I will update it again.

Replace error message and abort action in csv import plugin with a question for the user how to proceed
@pkess pkess force-pushed the csv_import_ignore_wrong_column_count branch from d21e8eb to 0bd4450 Compare November 18, 2024 18:31
@pkess
Copy link
Author

pkess commented Nov 18, 2024

Looks like i based my work on an outdated fork. I will update it again.

I rebased and updated the changes now.

@facontidavide
Copy link
Owner

no, of your CSV is malformed, it is your problem

@pkess
Copy link
Author

pkess commented Jun 16, 2025

So i created this pr more than 6 month ago without any feedback and now you are closing this with only this small feedback? I am not happy about this.

The reason for this is very common IMO: When data is converted from any file format to the CSV format the changes are written line by line. While this can take a long time you might want to get a preview to the data and try to load all data that was already converted. When i did this in the past the csv importer always complained about one line not being complete (the last line in the file that could just be skipped). And the csv failes to load.
So what i am doing is i copy the file that is being converted into, open it in a text editor and remove the last line. Then i can load it with plotjuggler. With this pr i could just load the file and there will be a message that i can ignore.

So @facontidavide i am asking you to think about this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants