fix(backups): no full backup#105
Merged
Aditya Niraula (AdityaNPL) merged 3 commits intomasterfrom May 8, 2022
Merged
Conversation
Aditya Niraula (AdityaNPL)
requested review from
Ryan Clare (Kaneraz) and
Alex Irion (alexirion10)
Ryan Clare (Kaneraz)
approved these changes
May 7, 2022
Contributor
Ryan Clare (Kaneraz)
left a comment
Ryan Clare (Kaneraz)
left a comment
There was a problem hiding this comment.
Looks correct.
When throwing a specific exception I prefer to make a new type, and catch it rather than just throw exception.
Also, it can be expected that a backup may not exist on each node, so the interface should change to be nullable. Save the exceptions for when something unexpected happens.
Contributor
Author
|
Ryan Clare (@Kaneraz) - I agree, maybe we can return |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.