Skip to content

fix(backups): no full backup #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aditya Niraula (AdityaNPL) merged 3 commits into from
May 8, 2022
Merged

fix(backups): no full backup #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
946da21
fix(backups): no full backup
AdityaNPL May 7, 2022
0cfe338
fix(backups): including DB name in exception
AdityaNPL May 7, 2022
d517a64
refactor(backups): Using `IsEmpty` instead of `Count==0`
AdityaNPL May 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/AgDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,19 @@ public List<BackupMetadata> RecentBackups()
{
// find most recent full backup LSN across all replica servers
var fullBackupLsnBag = new ConcurrentBag<decimal>();
_listener.ForEachAgInstance(s => fullBackupLsnBag.Add(s.Database(Name).MostRecentFullBackupLsn()));
_listener.ForEachAgInstance(s =>
{
try
{
fullBackupLsnBag.Add(s.Database(Name).MostRecentFullBackupLsn());
}
catch { }
});

// find all backups in that chain
if (fullBackupLsnBag.IsEmpty)
throw new Exception($"Could not find any full backups for DB '{Name}'");

var databaseBackupLsn = fullBackupLsnBag.Max();
var bag = new ConcurrentBag<BackupMetadata>();
_listener.ForEachAgInstance(s => s.Database(Name).BackupChainFromLsn(databaseBackupLsn)
Expand Down
7 changes: 6 additions & 1 deletion src/SmoFacade/Database.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,13 @@ public decimal MostRecentFullBackupLsn()
using var reader = cmd.ExecuteReader();
if(!reader.Read())
throw new Exception("MostRecentFullBackup SQL found no results");

var lsnValue = reader["most_recent_full_backup_checkpoint_lsn"];

return (decimal)reader["most_recent_full_backup_checkpoint_lsn"];
if (lsnValue == DBNull.Value)
throw new Exception("MostRecentFullBackup SQL found no results");

return (decimal)lsnValue;
}

public List<BackupMetadata> BackupChainFromLsn(decimal checkpointLsn)
Expand Down