fix: hardening sweep — file safety, timeouts, race conditions#21
Merged
Conversation
- Atomic writes for __startup.lua and .mcp.json (prevents corruption on kill) - Guard shutil.rmtree with .git check (prevents deleting non-repo dirs) - Strict allowlist regex for Demucs stem names (rejects special chars) - JSON depth limit for user profiles (prevents recursion exhaustion) - Prefer public FastMCP API for tool listing with private fallback - Add subprocess timeout for git remote check Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- TOCTOU race: cache profiles with post-load mtime, handle OSError on stat - Demucs timeout: wrap apply_model in ThreadPoolExecutor with 600s limit - Dep warnings: suppress authlib/matchering deprecation warnings in pytest - Output race: lock file (O_EXCL) prevents concurrent match_to_reference writes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__startup.luaand.mcp.json(prevents corruption on kill)shutil.rmtreewith.gitcheck (prevents deleting non-repo dirs)match_to_referencewritesTest plan
🤖 Generated with Claude Code