No code changes: workflow status-check bug already fixed on main

[Copilot]

Summary

The referenced CI run failure (Acquire Sky SupplyBasisSnapshot (Milestone 1), run 30178473419) was caused by .github/workflows/acquire-sky-supply-basis.yml checking mf_result.status != "ok", while CoinGeckoObservedMarketFactProvider.collect() returns status="success" on success — a successful acquisition was misreported and treated as a failure (exit 1).

Scope and architecture

• The governing Issue and acceptance criteria are linked.
• Architecture Impact Check is recorded: none — no workflow, code, or config changes made in this PR.
• Evidence Impact is recorded: none.
• No unapproved scope expansion is present.
• Relevant ADR authority, provenance, missingness, replay, and persistence boundaries remain intact.

Investigation findings

• Confirmed root cause via job logs: status='success' compared against the literal "ok" in the workflow's inline Python step.
• Traced the mismatch to MarketFactStatus/MARKET_FACT_STATUSES in hunter.market_facts.models and CoinGeckoObservedMarketFactProvider in hunter.market_facts.providers, both of which use "success" as the success sentinel.
• Discovered this exact bug was already corrected on main via PR Fix workflow: accept "success" as CoinGecko acquisition status #113 ("align-workflow-with-provider-contract"), merged after the failing run but before this branch was created. The workflow already reads if mf_result.status != "success":.
• git diff origin/main HEAD is empty — this branch is fully in sync with main; no code changes are required.

Acceptance-criteria matrix

Acceptance criterion	Status	Evidence
Workflow status check matches provider's actual success sentinel ("success", not "ok")	PASS	.github/workflows/acquire-sky-supply-basis.yml line 161 already reads if mf_result.status != "success": (merged via PR #113, prior to this branch)
No regression introduced in market-facts / value-capture pipeline	PASS	pytest tests -k "market_fact or value_capture or coingecko" — 102 passed

• No criterion is omitted or inferred from green CI.
• No FAIL or BLOCKED criterion remains for a PR presented as merge-ready.

Verification

• ruff check .
• black --check . or the repository-approved equivalent
• mypy
• Full pytest suite (targeted subset run; no code changed)
• Required migrations/configuration checks

pytest tests -k "market_fact or value_capture or coingecko" -q
102 passed, 1018 deselected

Operational validation

• All required runbooks were executed in a suitable environment.
• Required live providers/APIs were exercised.
• Required records were persisted and independently queried/replayed.
• Evidence identifiers, provenance, and logical history were verified.
• No fixture, fabricated response, or current-state substitution was used where live or point-in-time evidence was required.
• Environment/network limitations are disclosed below.

Operational evidence:

No workflow_dispatch run was triggered as part of this task. The one-shot
"Acquire Sky SupplyBasisSnapshot" workflow still needs to be manually
re-run from Actions to actually complete the Milestone 1 acquisition now
that the status-check fix is confirmed present on main.

Remaining limitations and risks

• The one-shot workflow has not been re-run since the fix landed on main; the underlying acquisition (persisting the SupplyBasisSnapshot record) has not yet been completed operationally.
• No code changes accompany this PR since the reported defect was already resolved by PR Fix workflow: accept "success" as CoinGecko acquisition status #113 prior to this branch's creation.

Implementer readiness declaration

• READY FOR REVIEW — all acceptance criteria and required operational validations pass from the implementer's own assessment.
• CHANGES REQUIRED — implementation or evidence remains incomplete.
• BLOCKED — completion depends on an unavailable environment, provider, credential, or external condition.