Skip to content

Conversation

@RalphSteinhagen
Copy link
Member

  • added missing last notify caching of in RestPlugin
  • improved MajordomoWorker notify() function call

@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 11:17 Inactive
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #71 (27f2f60) into main (827a38b) will increase coverage by 0.53%.
The diff coverage is 77.20%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #71      +/-   ##
============================================
+ Coverage     70.97%   71.51%   +0.53%     
- Complexity     2399     2435      +36     
============================================
  Files            87       87              
  Lines         10760    10804      +44     
  Branches       1647     1650       +3     
============================================
+ Hits           7637     7726      +89     
+ Misses         2179     2130      -49     
- Partials        944      948       +4     
Impacted Files Coverage Δ Complexity Δ
core/src/main/java/io/opencmw/rbac/RbacRole.java 80.00% <0.00%> (+80.00%) 5.00 <0.00> (+5.00)
...c/main/java/io/opencmw/server/ClipboardWorker.java 90.80% <50.00%> (-2.06%) 20.00 <0.00> (ø)
...va/io/opencmw/server/rest/MajordomoRestPlugin.java 69.72% <60.00%> (-1.40%) 51.00 <3.00> (+2.00) ⬇️
...c/main/java/io/opencmw/server/MajordomoWorker.java 88.52% <85.18%> (-2.66%) 26.00 <17.00> (+5.00) ⬇️
core/src/main/java/io/opencmw/rbac/RbacToken.java 96.77% <100.00%> (+96.77%) 18.00 <5.00> (+18.00)
...io/opencmw/concepts/aggregate/TestEventSource.java 62.16% <0.00%> (-1.36%) 7.00% <0.00%> (-1.00%)
...main/java/io/opencmw/client/OpenCmwDataSource.java 69.76% <0.00%> (-0.59%) 32.00% <0.00%> (-1.00%)
...in/java/io/opencmw/client/DataSourcePublisher.java 85.17% <0.00%> (ø) 54.00% <0.00%> (+1.00%)
core/src/main/java/io/opencmw/OpenCmwProtocol.java 57.91% <0.00%> (+7.23%) 1.00% <0.00%> (ø%)
...src/main/java/io/opencmw/server/rest/RestRole.java 100.00% <0.00%> (+25.00%) 2.00% <0.00%> (+1.00%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827a38b...27f2f60. Read the comment docs.

@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 11:24 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2021

This pull request introduces 2 alerts when merging 6f7d3e1 into 827a38b - view on LGTM.com

new alerts:

  • 2 for Boxed variable is never null

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

The lgtm issues seem valid but minor.

@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 13:14 Inactive
@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2021

This pull request introduces 2 alerts when merging 0053c70 into 827a38b - view on LGTM.com

new alerts:

  • 2 for Boxed variable is never null

@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 13:30 Inactive
@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 13:33 Inactive
@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 14:02 Inactive
@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 14:17 Inactive
@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 15:03 Inactive
@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 15:10 Inactive
@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 15:15 Inactive
@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 15:17 Inactive
@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 15:21 Inactive
@RalphSteinhagen RalphSteinhagen temporarily deployed to configure coverage March 18, 2021 15:41 Inactive
@RalphSteinhagen RalphSteinhagen merged commit ee37a4e into main Mar 18, 2021
@RalphSteinhagen RalphSteinhagen deleted the basicSampleUpdate branch March 18, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants