-
Notifications
You must be signed in to change notification settings - Fork 4
updated BasicSample and Notify handling #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RalphSteinhagen
commented
Mar 18, 2021
- added missing last notify caching of in RestPlugin
- improved MajordomoWorker notify() function call
…domoWorker notify() function call
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
============================================
+ Coverage 70.97% 71.51% +0.53%
- Complexity 2399 2435 +36
============================================
Files 87 87
Lines 10760 10804 +44
Branches 1647 1650 +3
============================================
+ Hits 7637 7726 +89
+ Misses 2179 2130 -49
- Partials 944 948 +4 Continue to review full report at Codecov.
|
|
This pull request introduces 2 alerts when merging 6f7d3e1 into 827a38b - view on LGTM.com new alerts:
|
wirew0rm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
The lgtm issues seem valid but minor.
|
This pull request introduces 2 alerts when merging 0053c70 into 827a38b - view on LGTM.com new alerts:
|
11ed30e to
be6e55a
Compare
be6e55a to
236f916
Compare