Skip to content

Conversation

@Soean
Copy link
Contributor

@Soean Soean commented Jun 18, 2025

No description provided.

Signed-off-by: Sören Wünsch <soeren.wrede@parshipgroup.com>
@timiwahalahti
Copy link
Member

Thank you!

I'm keeping this open, as there are likely going to be changes in strings for 0.4.0, so updating translations closer to the next release is probably needed.

@timiwahalahti timiwahalahti added this to the 0.4.0 milestone Jun 18, 2025
Signed-off-by: Sören Wünsch <soerenwrede@gmail.com>
@Ipstenu
Copy link
Contributor

Ipstenu commented Oct 27, 2025

@Soean @dertuxmalwieder - Is this ready for the current version?

@Ipstenu Ipstenu modified the milestones: 0.4.0, 1.1 Oct 27, 2025
@Ipstenu Ipstenu added question Further information is requested translation labels Oct 27, 2025
Soean added 2 commits October 27, 2025 20:17
Signed-off-by: Sören Wünsch <soeren.wrede@parshipgroup.com>
@Soean
Copy link
Contributor Author

Soean commented Oct 27, 2025

@Ipstenu Yes, I updated and translated it.

@dertuxmalwieder
Copy link

LGTM too. ;-)

@Ipstenu
Copy link
Contributor

Ipstenu commented Oct 27, 2025

Thank you both! You rule!

@costdev costdev modified the milestones: 1.1, 1.2 Nov 5, 2025
@afragen
Copy link
Contributor

afragen commented Dec 10, 2025

So we only really need the .po file as the rest are created via a GitHub Action here.

It also seems that there are conflicts with the .po in the PR. I know it's a big ask, but we can merge as soon as this is fixed.

@costdev costdev self-requested a review December 11, 2025 06:10
# Conflicts:
#	languages/fair-de_DE.l10n.php
#	languages/fair-de_DE.mo
#	languages/fair-de_DE.po
@Soean
Copy link
Contributor Author

Soean commented Dec 11, 2025

Thanks for your feedback. I updated the po file and merged the main branch.

@costdev
Copy link
Member

costdev commented Dec 11, 2025

@Soean Thanks a lot for the updates! ❤️

The last three commits aren't signed off so DCO is failing.

You can either:

  • Redo the commits but use commit -s -m "Message", OR
  • Rebase, and manually add Signed-off-by: Sören Wünsch <soeren.wrede@parshipgroup.com> to each commit, OR
  • Simply reply here on the PR confirming that you have the rights to your contribution, and that the FAIR project has the right to distribute it under our license, which means I can force DCO to pass.

Signed-off-by: Sören Wünsch <soeren.wrede@parshipgroup.com>
Signed-off-by: Sören Wünsch <soeren.wrede@parshipgroup.com>
Signed-off-by: Sören Wünsch <soeren.wrede@parshipgroup.com>
@Soean
Copy link
Contributor Author

Soean commented Dec 11, 2025

@costdev You are right, I fixed it

@costdev costdev merged commit c783250 into fairpm:main Dec 11, 2025
46 checks passed
@Soean Soean deleted the i18n/de branch December 11, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants