Skip to content

Conversation

@johnbillion
Copy link
Contributor

The bundles created for the release bundle FAIR with every version of WordPress back to 4.7, but FAIR only supports 5.4 and higher.

This adjusts the bundle script so it skips bundles for unsupported versions of WordPress, and fixes a path issue which was preventing rsync from running on my macOS machine.

Steps to test:

  1. Run ./bin/bundle.sh
  2. Confirm the output shows that older versions were skipped:
Skipping 5.3.20 (older than 5.4)
Skipping 5.2.23 (older than 5.4)
Skipping 5.1.21 (older than 5.4)
Skipping 5.0.24 (older than 5.4)
Skipping 4.9.28 (older than 5.4)
Skipping 4.8.27 (older than 5.4)
Skipping 4.7.31 (older than 5.4)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Signed-off-by: John Blackbourn <john@johnblackbourn.com>
Signed-off-by: John Blackbourn <john@johnblackbourn.com>
@kasparsd
Copy link

A question unrelated to this pull request -- what's the reason for creating all these releases? It definitely made me think before downloading the release for install. I'm wondering how users would know which version to pick? That information isn't part of the release notes or in the README.

fair-releases

p.s. happy to open an issue if we want to discuss that in isolation.

@Ipstenu
Copy link
Contributor

Ipstenu commented Oct 27, 2025

@kasparsd

I'm wondering how users would know which version to pick?

Hopefully the users aren't using Github, but the answer is the one named fair-plugin*

The others (with wordpress) are installers for WP core with our plugin auto-added (like Akismet or Hello Dolly)

@rmccue I'm flagging this for the 1.2 release - I do think there's a point we don't need to build things we can't support :D

@Ipstenu Ipstenu requested a review from rmccue October 27, 2025 19:26
@Ipstenu Ipstenu added enhancement New feature or request build process labels Oct 27, 2025
@Ipstenu Ipstenu added this to the 1.2 milestone Oct 27, 2025
@kasparsd
Copy link

Hopefully the users aren't using Github

I believe the current instructions are to download the plugin from GitHub releases:

fair-plugin/README.md

Lines 15 to 17 in 4be6646

FAIR can be installed manually by downloading the latest zip from releases and install it via your WordPress admin dashboard.
* [FAIR Releases](https://github.com/fairpm/fair-plugin/releases)

https://github.com/fairpm/.github/blob/734cf38798dc9eeb8bdab1cba38ddbcd37bd48de/profile/README.md?plain=1#L9-L10

So I did that and was really overwhelmed with the amount of ZIPs I saw there 😅

All instances of "Install Plugin" appear to link to the GitHub releases:

Screenshots for reference:

tip blog-post

Copy link
Member

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works great!

Separate from this PR, to facilitate testing in different setups, we should probably remove the hardcoded assumed temporary directory in favour of $TMPDIR with a fallback to /tmp if the variable isn't defined. At the least, we should use the script's $DIST_DIR variable consistently instead of /tmp/fair-dist.

@costdev costdev merged commit 5ab6463 into fairpm:main Dec 11, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build process enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants