Skip to content

Updating ROCrate cleanIdentifier method #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlev71 merged 1 commit into from
Jun 24, 2026
Merged

Updating ROCrate cleanIdentifier method #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion fairscape_models/rocrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import urllib.parse
from typing import Any, Dict, List, Literal, Optional, Union
import re
from pydantic import BaseModel, Field, ConfigDict, model_validator

from fairscape_models.fairscape_base import IdentifierValue, DEFAULT_CONTEXT
Expand Down Expand Up @@ -430,7 +431,20 @@ def cleanGUID(metadata):
""" Clean metadata guid property from full urls to ark:{NAAN}/{postfix}
"""
if hasattr(metadata, 'guid') and isinstance(metadata.guid, str) and "http" in metadata.guid:
metadata.guid = urllib.parse.urlparse(metadata.guid).path.lstrip('/')
# old metadata parsing
#metadata.guid = urllib.parse.urlparse(metadata.guid).path.lstrip('/')

# find ark:NAAN within string
try:
match = re.search(
pattern="ark:[0-9]{5}/.+$",
string=metadata.guid
)
metadata.guid = match.group()
except AttributeError:
# TODO warm about missing ark in guid
pass


def cleanIdentifierList(identifier_list):
"""Helper to clean a list of identifiers"""
Expand Down
Loading