Merged
Conversation
…s previous user email. When registering a new user, check that no existing user has an email matching the username. Prevents a login name collision when one user registers with the email address user@test.com and a second user tries to register with the username user@test.com. Props buutqn, dunhakdis, roytanck, ajayver. Fixes #57394. git-svn-id: https://develop.svn.wordpress.org/trunk@55358 602fd350-edb4-49c9-b593-d223f7449a82
… deleted. This changeset fixes an issue where the available theme updates count was not updated after a theme is deleted. Props nazmulhasan103, riccardodicurti, sabernhardt, ironprogrammer, costdev, robinwpdeveloper, rahmantasnia. Fixes #57183. git-svn-id: https://develop.svn.wordpress.org/trunk@55359 602fd350-edb4-49c9-b593-d223f7449a82
…s an existing email. Move the test next to the other tests for `user_login`. Follow-up to [55358]. See #57394. git-svn-id: https://develop.svn.wordpress.org/trunk@55360 602fd350-edb4-49c9-b593-d223f7449a82
…bject. Previously, the `rest_pre_dispatch` filter could be used to return a `WP_Error` instance. This would cause a fatal error for `rest_post_dispath` filters that were rightly expecting a `WP_REST_Response` object to be passed instead. Props DaveFX, felipeelia. Fixes #56566. git-svn-id: https://develop.svn.wordpress.org/trunk@55361 602fd350-edb4-49c9-b593-d223f7449a82
Non-Latin characters can break SVN checkout in some environments. Follow up from [55294]. See #57329, #57761. git-svn-id: https://develop.svn.wordpress.org/trunk@55362 602fd350-edb4-49c9-b593-d223f7449a82
This avoids an extra redirect and brings more consistency with other links to the PHP website in core. Follow-up to [42980], [50914], [55355]. See #56792. git-svn-id: https://develop.svn.wordpress.org/trunk@55363 602fd350-edb4-49c9-b593-d223f7449a82
…nk functions. This commit renames a few internal variables for better clarity and consistency: * `$nextpage` to `$next_page` in: * `get_next_posts_page_link()` * `get_next_posts_link()` * `get_next_comments_link()` * `$nextpage` to `$previous_page` in: * `get_previous_posts_page_link()` * `$prevpage` to `$previous_page` in: * `get_previous_comments_link()` Includes minor code layout fixes for better readability. Follow-up to [5045], [8502], [8961], [28111]. Props dalirajab, SergeyBiryukov. Fixes #57746. git-svn-id: https://develop.svn.wordpress.org/trunk@55364 602fd350-edb4-49c9-b593-d223f7449a82
… files. The `$post_ID` variable is [https://github.com/WordPress/WordPress-Coding-Standards/blob/546f59c67854589bb8f6b49a30e642e75ff419ad/WordPress/Sniffs/NamingConventions/ValidVariableNameSniff.php#L54 technically allowed in WPCS], as there is a global of the same name that needs to remain for backward compatibility. However, this name is mostly a remnant of legacy code, and switching to `$post_id` where appropriate brings more consistency with the rest of core. Additionally, this commit resolves a few WPCS warnings in core: {{{ Variable "$post_IDs" is not in valid snake_case format }}} This affects: * Function parameters in: * `add_meta()` * `post_preview()` * `WP_Embed::delete_oembed_caches()` * `WP_Embed::cache_oembed()` * `wp_get_post_cats()` * `wp_set_post_cats()` * `wp_unique_post_slug()` * `wp_set_post_categories()` * `wp_check_post_hierarchy_for_loops()` * `wp_add_trashed_suffix_to_post_name_for_trashed_posts()` * `wp_filter_wp_template_unique_post_slug()` * `wp_xmlrpc_server::add_enclosure_if_new()` * `wp_xmlrpc_server::attach_uploads()` * `wp_xmlrpc_server::mt_getTrackbackPings()` * Internal variables in: * `wp_ajax_inline_save()` * `wp_ajax_set_post_thumbnail()` * `wp_ajax_get_post_thumbnail_html()` * `edit_post()` * `bulk_edit_posts()` * `wp_write_post()` * `WP_Embed::shortcode()` * `wp_insert_post()` * `wp_xmlrpc_server::_insert_post()` * `wp_xmlrpc_server::blogger_getPost()` * `wp_xmlrpc_server::blogger_newPost()` * `wp_xmlrpc_server::blogger_editPost()` * `wp_xmlrpc_server::blogger_deletePost()` * `wp_xmlrpc_server::mw_getPost()` * `wp_xmlrpc_server::mw_newPost()` * `wp_xmlrpc_server::mw_editPost()` * `wp_xmlrpc_server::mt_getPostCategories()` * `wp_xmlrpc_server::mt_setPostCategories()` * `wp_xmlrpc_server::mt_publishPost()` * `wp_xmlrpc_server::pingback_ping()` * Hook parameters in: * `oembed_ttl` * `embed_oembed_html` * `wp_insert_post_parent` * `add_trashed_suffix_to_trashed_posts` * `pre_post_update` * `edit_attachment` * `attachment_updated` * `add_attachment` * `edit_post_{$post->post_type}` * `edit_post` * `post_updated` * `save_post_{$post->post_type}` * `save_post` * `wp_insert_post` * `pre_wp_unique_post_slug` * `wp_unique_post_slug` * `xmlrpc_call_success_blogger_newPost` * `xmlrpc_call_success_blogger_editPost` * `xmlrpc_call_success_blogger_deletePost` * `xmlrpc_call_success_mw_newPost` * `xmlrpc_call_success_mw_editPost` Note: The name change only affects variable names and DocBlocks. The change does not affect the `$post_ID` global still used in a few places. Follow-up to [51399], [52958], [53723], [53729], [55190], [55308], [55334]. Props mahekkalola, tanjimtc71, SergeyBiryukov. Fixes #57692. git-svn-id: https://develop.svn.wordpress.org/trunk@55365 602fd350-edb4-49c9-b593-d223f7449a82
Updates the `@wordpress` packages to include the following change: - Pin `valtio` version References: [WordPress/gutenberg@ccabeef Gutenberg's commit for publishing the packages] Props ntsekouras. See #57471. git-svn-id: https://develop.svn.wordpress.org/trunk@55366 602fd350-edb4-49c9-b593-d223f7449a82
…t()` is available. This resolves a fatal error and displays an actionable message if the `mysqli` PHP extension is missing. Previously, `wp_check_php_mysql_versions()` performed an early check whether `mysql`, `mysqli`, or `mysqlnd` extensions are loaded, but that did not work if the `mysqlnd` extension is the only one present. Checking specifically for `mysqli_connect()` or `mysql_connect()` functions should be a more reliable approach and more closely mirrors the existing checks in the `wpdb` class. Follow-up to [1955], [4489], [7234], [12732], [19760], [27257], [36434]. Props bgin, desrosj, dimadin, ipajen, hellofromTonya, sc0ttkclark, azaozz, SergeyBiryukov. Fixes #51988. git-svn-id: https://develop.svn.wordpress.org/trunk@55367 602fd350-edb4-49c9-b593-d223f7449a82
Fixes the conditions for when to enqueue the opinionated block styles (i.e. `'wp-block-library-theme'` stylesheet): * the theme adds `'wp-block-styles'` theme support; * and no editor styles are declared. This resolves an issue with themes that do not add the `'wp-block-styles'` theme support while not impacting themes that do. Follow-up to [53419], [52069], [50761], [44157]. Props mikachan, costdev, glendaviesnz, hellofromTonya, jffng, mamaduka, ndiego, poena, sannevndrmeulen, scruffian. Fixes #57561. git-svn-id: https://develop.svn.wordpress.org/trunk@55368 602fd350-edb4-49c9-b593-d223f7449a82
Introduces client and server side validation to ensure the `replytocom` query string parameter can not be exploited to reply to an unapproved comment or display the name of an unapproved commenter. This only affects commenting via the front end of the site. Comment replies via the dashboard continue their current behaviour of logging the reply and approving the parent comment. Introduces the `$post` parameter, defaulting to the current global post, to `get_cancel_comment_reply_link()` and `comment_form_title()`. Introduces `_get_comment_reply_id()` for determining the comment reply ID based on the `replytocom` query string parameter. Renames the parameter `$post_id` to `$post` in `get_comment_id_fields()` and `comment_id_fields()` to accept either a post ID or `WP_Post` object. Adds a new `WP_Error` return state to `wp_handle_comment_submission()` to prevent replies to unapproved comments. The error code is `comment_reply_to_unapproved_comment` with the message `Sorry, replies to unapproved comments are not allowed.`. Props costdev, jrf, hellofromtonya, fasuto, boniu91, milana_cap. Fixes #53962. git-svn-id: https://develop.svn.wordpress.org/trunk@55369 602fd350-edb4-49c9-b593-d223f7449a82
Modifies `WP_Http::make_absolute_url()` to prevent it from dropping URL fragments, this in turn fixes the same issue for `links_add_base_url()`. Props costdev, sergeybiryukov, dshanske, schlessera, jrf, desrosj, dd32. Fixes #56231. git-svn-id: https://develop.svn.wordpress.org/trunk@55370 602fd350-edb4-49c9-b593-d223f7449a82
Includes the following changes: - Upgrade Playwright to 1.30.0 - [Block Editor - Inserter]: preload media categories empty check - client side - Navigation: Fixes undo and redo for nesting operations in the navigation block's inspector - Fix: OffCanvasEditor does not inserts submenu on collapsed items. - OffCanvasEditor: Only allow some blocks to be converted to submenus - Navigation: Updates "Add Submenu item" text to "Add Submenu link" - Update: Make OffCanvasEditor use LeafMoreMenu by default. - Template Part: Performance: Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet() - Widget Editor: Fix a problem with 'Move to Widget Area' button not working - Reusable Blocks: Use React 18 rendering for import dropdown - useAsyncList: flush state updates when processing queue - Refactor the site editor URLs for better backward compatibility - Template editor: only disable the save button if no changes rather than hiding it - [Quote]: Fix deprectated large style specificity rule - Style Book: Allow button text labels for style book icon - List View: Scroll selected block into view when single block selection changes - Post editor: revert iframed editor for WP core only - Fix the Publish region position and focus style. - Remove "& Shadow" from the Border ScreenHeader title - Site editor: specify focus state color for template navigation button References: [WordPress/gutenberg@1e2b2f6 Gutenberg's commit for publishing the packages] Props ntsekouras, ellatrix. See #57471. git-svn-id: https://develop.svn.wordpress.org/trunk@55392 602fd350-edb4-49c9-b593-d223f7449a82
…pTheme.php`. Follow-up to [814/tests], [904/tests], [50967]. Props mukesh27, costdev. See #56792. git-svn-id: https://develop.svn.wordpress.org/trunk@55393 602fd350-edb4-49c9-b593-d223f7449a82
…he new network user screen. This reverts the email input field back to its previous state (before [55026]), except for the expected addition of the `required` attribute. Follow-up to [55026]. Props johnbillion. Fixes #38460. git-svn-id: https://develop.svn.wordpress.org/trunk@55394 602fd350-edb4-49c9-b593-d223f7449a82
Restores the global `$comment` assignment in `comment_form_title()`, which was mistakely removed in [55369].
As noted in the function's DocBlock:
{{{
@internal The $comment global must be present to allow template tags access to the current comment. See https://core.trac.wordpress.org/changeset/36512.
}}}
Follow-up to [55369].
Props hellofromTonya, costdev.
Fixes #53962.
git-svn-id: https://develop.svn.wordpress.org/trunk@55395 602fd350-edb4-49c9-b593-d223f7449a82
This fixes a regression introduced in [41163], where the link in change confirmation emails for users with no roles in a multisite install was incorrect, causing them to be unable to change their email address. This changeset replaces `admin_url()` with `self_admin_url()` to restore the previous fix. Follow-up to [38876], [40632], [41165], [41163]. Props roytanck, SergeyBiryukov, johnbillion, afrin29. Fixes #57164. git-svn-id: https://develop.svn.wordpress.org/trunk@55396 602fd350-edb4-49c9-b593-d223f7449a82
Previously, the wp_check_password function was used for validating keys, while the PasswordHash class was used for creating keys. This would prevent Recovery Mode from working on sites that provide a custom implementation for the wp_check_password pluggable function. Props calvinalkan. Fixes #56787. git-svn-id: https://develop.svn.wordpress.org/trunk@55397 602fd350-edb4-49c9-b593-d223f7449a82
…locks. Props paulkevan, costdev, audrasjb, SergeyBiryukov. See #56792. git-svn-id: https://develop.svn.wordpress.org/trunk@55398 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@55399 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@55400 602fd350-edb4-49c9-b593-d223f7449a82
…lazyload()`. This ensures the `$term_ids` variable only contains term IDs and is not filled with full term objects due to deprecated term caching. Introduced in [55252]. Props skithund, Chouby, joemcgill, flixos90, ocean90. Fixes #57150. git-svn-id: https://develop.svn.wordpress.org/trunk@55401 602fd350-edb4-49c9-b593-d223f7449a82
When the HTML API was introduced a number of fields were switched from private visibility to protected so that Gutenberg and other systems could more easily enhance the behaviors through subclassing. The $this->html property was overlooked but important for systems using the Tag Processor to stich HTML, specifically performing operations on innerHTML and innerText. Follow-up [55203]. Props dmsnell. See #57575. git-svn-id: https://develop.svn.wordpress.org/trunk@55402 602fd350-edb4-49c9-b593-d223f7449a82
This aims to avoid timeout in Imagick operations. Previously, Imagick operations could silently error by timeout and produce unexpected results. The new `::set_imagick_time_limit()` method, now used in `::resize()` and `::crop()`, will better handle garbage collection in these cases as well as better align Imagick's timeout with PHP timeout, assuming it is set. Props drzraf, audrasjb, costdev, antpb, SergeyBiryukov. Fixes #52569. git-svn-id: https://develop.svn.wordpress.org/trunk@55404 602fd350-edb4-49c9-b593-d223f7449a82
Adds Deep, Outlined, and Crisp default shadow presets to Core's `theme.json` file. Updates the Natural and Sharp `'shadow'` styles. These shadow presets are used to populate the Shadow tools in the Site Editor's Global Styles UI. References: * [WordPress/gutenberg#46502 Gutenberg PR 46502] Follow-up to [55176]. Props franz00, madhudollu, ajlende, beafialho, costdev, dhrupo, fabiankaegy, hellofromTonya, jameskoster, joen, kellychoffman, mamaduka, mtias, oandregal, priethor, richtabor, scruffian. Fixes #57708. See #57559. git-svn-id: https://develop.svn.wordpress.org/trunk@55405 602fd350-edb4-49c9-b593-d223f7449a82
…esponding new text string from the implementation of the new `wp_save_post_revision_revisions_before_deletion` filter. While the guard condition was technically correct, it's not practical or necessary to provide this protection for every use of every filter, and it adds unnecessary burden to translators to provide translations for strings that will likely not be seen. Follow up to [55254]. Fixes #57320 git-svn-id: https://develop.svn.wordpress.org/trunk@55406 602fd350-edb4-49c9-b593-d223f7449a82
…sor.
Setting a bookmark on a tag should set its "start" position before the opening "<", e.g.:
{{{
<div> Testing a <b>Bookmark</b>
----------------^
}}}
The previous calculation assumed this is always one byte to the left from `$tag_name_starts_at`.
However, in a closing tag that index points to a solidus symbol "/":
{{{
<div> Testing a <b>Bookmark</b>
----------------------------^
}}}
The bookmark should therefore start two bytes before the tag name:
{{{
<div> Testing a <b>Bookmark</b>
---------------------------^
}}}
This changeset achieves this by:
* Using the correct starting index for closing tag bookmarks.
* Adding `array( 'tag_closers' => 'visit' )` in `WP_HTML_Tag_Processor::seek()`.
Follow-up to [55203].
Props zieladam, dmsnell, flixos90.
Fixes #57787.
See #57575.
git-svn-id: https://develop.svn.wordpress.org/trunk@55407 602fd350-edb4-49c9-b593-d223f7449a82
…dit Site: Settings screen. This type of transformation isn't always appropriate, especially for non-English language sites. Displaying the original option name makes it more clear what option is being changed. Props SergeyBiryukov, sabernhardt, afrin29, afshanadiya Fixes #50572 git-svn-id: https://develop.svn.wordpress.org/trunk@55408 602fd350-edb4-49c9-b593-d223f7449a82
The `rss_widget_feed_link` filter added in [52031] documents the parameter as a string, but recommends removing by returning false. Change the recommendation and documentation to make this consistent and update Twenty Twenty One to use the new recommended return value. Maintains documentation as possibly returning `false` for backwards compatibility. Props sabernhardt, Mista-Flo. Fixes #57594. git-svn-id: https://develop.svn.wordpress.org/trunk@55409 602fd350-edb4-49c9-b593-d223f7449a82
Remove link to release video, update split controls image. Follow-up to [55449], [55499], [55545]. Props laurlittle, richtabor. Fixes #57477. git-svn-id: https://develop.svn.wordpress.org/trunk@55573 602fd350-edb4-49c9-b593-d223f7449a82
…link Remove the green background from the "dot" accent, to prevent low contrast for the dismiss button. Use menu colors for the background on alternate color schemes. Remove the "Edit styles" link as there is no longer a direct link to the global styles section of the site editor. Follow-up to [55451]. Props sabernhardt, ryokuhi, laurlittle, richtabor. Fixes #57759. git-svn-id: https://develop.svn.wordpress.org/trunk@55574 602fd350-edb4-49c9-b593-d223f7449a82
In the object-cache.php file used for unit tests, the add method did not work as expected. Other object cache plugins and core, have a check to see if the key exists in memory before writing it. Without this check, it used to write unnecessarily to the cache. Props spacedmonkey, SergeyBiryukov. Fixes #57963. git-svn-id: https://develop.svn.wordpress.org/trunk@55577 602fd350-edb4-49c9-b593-d223f7449a82
To fix the dynamic properties, the following changes are included: * Removes `WP_Admin_Bar::__get()`. * Declares `menu` as a property on the class, deprecates it, and initializes it to an empty array. * Removes the unused 'proto' dynamic property. Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. == Why remove the `WP_Admin_Bar::__get()` magic method? tl;dr The magic method is no longer needed. The magic method only handled the `menu` and `proto` dynamic properties. Introducing a full set of magic methods is overkill for this class. Instead of having to maintain magic methods, this changeset instead directly addresses the 2 properties (see below). == Why declare the `menu` property on the class? tl;dr To simplify the code while maintaining backwards compatibility for extenders who are using this deprecated property. The `menu` property was introduced during the 3.1.0 ''development cycle'' as a declared property [15671]. Its purpose was to ''internally'' hold the menu structure. During the WP 3.3.0 development cycle, it was replaced by a new `private` property called `nodes` (see [19120]). But breakage reports from extenders caused it to be restored. [19501] added the `__get()` magic method, i.e. for handling it as a dynamic property, and deprecated it. >We're not going to maintain compat for $menu. Suggest we make it array() and plugins will have to deal. We can throw a _deprecated_argument() and push them to use the new methods. ~ Source: [https://core.trac.wordpress.org/ticket/19371#comment:17 see #19371 comment 17] [https://wpdirectory.net/search/01GSTW1X69TBN8FH3SY7V8KPY5 A search of the wp.org plugins and themes repository] shows that a few plugins are still using this deprecated property. To maintain backwards compatibility, `menu` is moved back to the class as a declared property, set to an empty array (as it's been since 3.3.0), and deprecated in the property's description. == Why remove the `proto` dynamic property? tl;dr * It was not intended to be released in 3.1. * There are no usages of it in Core or in the WP.org's plugin or theme directories. * It should be safe to remove. This property was first introduced in the WP 3.1.0 ''development cycle'' to replace the `PROTO` constant (see [16038]) for protocol handling for the admin bar's hyperlinks. [16077] replaced the property's usages with URL functions such as `get_admin_url()` and `admin_url()`. But it missed removing the property, which was no longer needed or used. It was relocated to the `__get()` magic method as a dynamic property when the `menu` property was restored (see [19501]). A search of WP.org's plugins and themes repositories shows no usages of the property. Core hasn't used it since the removed in [16038] before 3.1 final release. It should be safe to remove it, but committing very early in the 6.3 alpha cycle to give time for reports of usages, if there are any. References: * A [https://www.youtube.com/watch?v=vDZWepDQQVE&t=9362s live open public working session] where these changes were discussed and agreed to. * [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties]. Follow-up to [19501], [19120], [16308], [16038], [15671]. Props antonvlasenko, hellofromTonya, jrf, markjaquith, desrosj, ironprogrammer, peterwilsoncc, SergeyBiryukov. See #56876, #56034. git-svn-id: https://develop.svn.wordpress.org/trunk@55580 602fd350-edb4-49c9-b593-d223f7449a82
… implementation. In a previous commit, the `::sanitize_expiration()` call in the `::add()` method was moved closer to where the value is used. This commit does the same for the other methods: * `::cas()` * `::replace()` * `::set()` * `::setMulti()` Follow-up to [40561], [55577]. See #57841, #57963. git-svn-id: https://develop.svn.wordpress.org/trunk@55581 602fd350-edb4-49c9-b593-d223f7449a82
…all screens. This fixes an alignement issue on small screens in the language switcher button displayed on the Login screen. Follow-up to [52058], [52417]. Props sabernhardt. Fixes #57617. git-svn-id: https://develop.svn.wordpress.org/trunk@55582 602fd350-edb4-49c9-b593-d223f7449a82
Includes: * Renaming some tests for clarity. * Moving some tests to a more appropriate place. * Moving the `@covers` tag to the top of the class. * Using consistent formatting for assertion messages. Follow-up to [27767], [41849], [44587], [55569]. See #57841. git-svn-id: https://develop.svn.wordpress.org/trunk@55583 602fd350-edb4-49c9-b593-d223f7449a82
This reverts the changes implemented in [55358] and [55360]. Changeset [55358] was committed to prevent login name collision when one user registers with the email address `user@example.com` and a second user tries to register with the username `user@example.com`. However, it also introduced a potential backward compatibility issues for plugins that use `wp_update_user()`. When updating an existing user, it throws an `existing_user_email_as_login` error if the email address is also used for the user login, due to the code introduced in [55358]. This changeset removes the new scenario added in [55358] and [55360], restoring the `wp_insert_user()` function back to its previous state. Props polevaultweb, audrasjb, costdev, peterwilsoncc, hellofromTonya, SergeyBiryukov, azaozz. See #57967, #57394. git-svn-id: https://develop.svn.wordpress.org/trunk@55584 602fd350-edb4-49c9-b593-d223f7449a82
…opriate place. Back when this test was introduced, `wp_list_pages()` did not have its own test class. It does now, so the test can be moved there, instead of being hidden among `get_pages()` tests. Includes: * Updating the test name for clarity. * Adding an unique message for each assertion. Follow-up to [27755], [28400]. See #57841. git-svn-id: https://develop.svn.wordpress.org/trunk@55588 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [55588]. See #57841. git-svn-id: https://develop.svn.wordpress.org/trunk@55589 602fd350-edb4-49c9-b593-d223f7449a82
This aims to make the tests more discoverable and easier to expand. Includes removing a basic test hidden among `get_pages()` tests, as there is already a more comprehensive set of tests available. Follow-up to [1279/tests], [28399], [31338]. See #57841. git-svn-id: https://develop.svn.wordpress.org/trunk@55590 602fd350-edb4-49c9-b593-d223f7449a82
…classes. This aims to bring some consistency to the location of post template function tests, as well as to make the tests more discoverable and easier to expand. Includes: * Adding `@covers` tags. * Renaming `get_post_parent()` and `has_post_parent()` tests to match the names of the functions. Follow-up to [28398], [31522], [34654], [34950], [50127], [50396], [54717], [54726], [55590]. See #57841. git-svn-id: https://develop.svn.wordpress.org/trunk@55591 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [10990], [11162], [11217], [37059]. Props jenilk. Fixes #57317. git-svn-id: https://develop.svn.wordpress.org/trunk@55592 602fd350-edb4-49c9-b593-d223f7449a82
…u.php`. Follow-up to [14248], [15008], [37748]. Props jenilk, johnbillion. Fixes #57318. git-svn-id: https://develop.svn.wordpress.org/trunk@55593 602fd350-edb4-49c9-b593-d223f7449a82
…d()`. Follow-up to [25421], [25823], [25859]. Props sakibmd, jrf, patelmohip, akmelias. See #57680. git-svn-id: https://develop.svn.wordpress.org/trunk@55594 602fd350-edb4-49c9-b593-d223f7449a82
…d theme installer. Follow-up to [48390]. Props sakibmd, jrf, patelmohip, akmelias. Fixes #57680. git-svn-id: https://develop.svn.wordpress.org/trunk@55595 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [55593]. See #57318. git-svn-id: https://develop.svn.wordpress.org/trunk@55596 602fd350-edb4-49c9-b593-d223f7449a82
…se_query()`. Follow-up to [55248]. Props tmatsuur. Fixes #57996. git-svn-id: https://develop.svn.wordpress.org/trunk@55597 602fd350-edb4-49c9-b593-d223f7449a82
This changeset introduced a regression for partial-hour timezones such as +05:30 UTC which is India and Sri Lanka. How? These timezones are in float. The change made in [55054] type casted them to integer which dropped the decimal for the partial-hour, making the time inaccurate. For example, +05:30 UTC (India and Sri Lanka)'s `'gmt_offset'` is `5.5`, but with the changeset, it was changed to `5`. Reverting the changeset restores the original state of `current_time()` and thus resolves the regression. Props reputeinfosystems, Rarst, hellofromTonya, desrosj, audrasjb, sergeybiryukov, costdev, priethor, francina, nekojonez, codingchicken, cbringmann. See #57035. Fixes #57998. git-svn-id: https://develop.svn.wordpress.org/trunk@55598 602fd350-edb4-49c9-b593-d223f7449a82
In the About page, replaces the `#` placeholder with the link to the Field Guide. Follow-up to [55573], [55449], [55499], [55545]. Props vladytimy, ocean90. Fixes #57998. git-svn-id: https://develop.svn.wordpress.org/trunk@55600 602fd350-edb4-49c9-b593-d223f7449a82
On the About page, wraps the Field Guide's link in `__()` to provide a localized field guide, when available. Follow-up to [55600]. Props davidbaumwald, sergeybiryukov, desrosj, javiercasares, oglekler, mukesh27, clorith, eboxnet, costdev, ocean90. Fixes #57477. git-svn-id: https://develop.svn.wordpress.org/trunk@55601 602fd350-edb4-49c9-b593-d223f7449a82
…format`. This fixes a few WPCS warnings along the lines of: * Array double arrow not aligned correctly * Equals sign not aligned with surrounding statements * Usage of ELSE IF is discouraged; use ELSEIF instead Follow-up to [55099], [55192], [55194], [55271]. Props davidbaumwald, jrf, SergeyBiryukov. Fixes #57994. git-svn-id: https://develop.svn.wordpress.org/trunk@55606 602fd350-edb4-49c9-b593-d223f7449a82
In the `fill_descendants` method in `WP_Comment_Query`, there is a loop the calls `wp_cache_get` to get `child comments. Instead of getting one key at a time, use `wp_cache_get_multiple` and get all keys at once. Props spacedmonkey, tillkruess, mukesh27. Fixes #57803. git-svn-id: https://develop.svn.wordpress.org/trunk@55607 602fd350-edb4-49c9-b593-d223f7449a82
…ent object id. The existing lazy loading meta api, creates a queue of ids, to be primed, if the `get_comment_meta` or `get_term_meta` functions are called. However, it did not check to see if the requested id was in the queue, before prime all the ids in the queue. Now, it adds the id to the queue, is not already in the queue, saving a cache lookup / database query. Props spacedmonkey, peterwilsoncc, mukesh27, flixos90. Fixes #57901. git-svn-id: https://develop.svn.wordpress.org/trunk@55608 602fd350-edb4-49c9-b593-d223f7449a82
…me.json not present. Check to see if the theme.json file exists before processing the rest of the code in `_wp_theme_json_webfonts_handler`. This improves performance by not trying to parse the theme.json, early in the bootstrap process. Props spacedmonkey, hellofromTonya, flixos90. Fixes #57814. git-svn-id: https://develop.svn.wordpress.org/trunk@55612 602fd350-edb4-49c9-b593-d223f7449a82
In [55612] a change was added that made two unit tests fail. Fix these test by forcing `get_merged_data` method to run. Props spacedmonkey, mukesh27. See #57814. git-svn-id: https://develop.svn.wordpress.org/trunk@55613 602fd350-edb4-49c9-b593-d223f7449a82
…link()`. Follow-up to [9112], [9406], [11011], [11380], [11383], [44659]. Props chintan1896, ankitmaru. Fixes #58025. git-svn-id: https://develop.svn.wordpress.org/trunk@55614 602fd350-edb4-49c9-b593-d223f7449a82
…u.php`. This ensures that post type or taxonomy name is consistently escaped in: * `wp_nav_menu_item_post_type_meta_box()` * `wp_nav_menu_item_taxonomy_meta_box()` Follow-up to [14248], [23707]. Props zenaulislam, SergeyBiryukov. Fixes #57110. git-svn-id: https://develop.svn.wordpress.org/trunk@55615 602fd350-edb4-49c9-b593-d223f7449a82
…av-menu.php`. It is best to always escape the complete value of an attribute, not a partial value, as otherwise the escaping could be (partially) undone when the values are joined together. While the hardcoded prefix/suffix values in this case don't necessarily create that risk, those may change to values which could be problematic, so making it a habit to escape the value in one go is best practice. Includes: * Moving a few `esc_url()` calls closer to the actual output and escaping the hash parts too. * Wrapping a few long lines for better readability. Follow-up to [14248], [23707], [42217], [55615]. Props jrf, SergeyBiryukov. Fixes #57110. git-svn-id: https://develop.svn.wordpress.org/trunk@55616 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.