feat(rds): add multi-engine support (PostgreSQL, MySQL, MariaDB) by vieiralucas · Pull Request #220 · faiscadev/fakecloud

vieiralucas · 2026-04-10T05:02:49Z

Summary

Adds support for multiple database engines and versions in RDS:

PostgreSQL (4 versions):

16.3, 15.5, 14.10, 13.13

MySQL (3 versions):

8.0.35, 8.0.28, 5.7.44

MariaDB (2 versions):

10.11.6, 10.6.16

Implementation:

Runtime selects Docker images based on engine/version
Engine-specific environment variables (POSTGRES_, MYSQL_, MARIADB_*)
Default ports: 5432 (postgres), 3306 (mysql/mariadb)
Default parameter groups for all engine families
Validation updated for all engines

Test plan

✅ All existing RDS tests pass with updated assertions
✅ Unit tests verify all 9 engine versions
✅ Clippy clean

Summary by cubic

Adds multi-engine RDS support (PostgreSQL, MySQL, MariaDB) across 9 versions and 7 instance classes, plus backup and Multi-AZ metadata on instances. The runtime picks engine-aware Docker images, ports, defaults, and validation, with 63 orderable options exposed by the API.

New Features
- Engines/versions: PostgreSQL 16.3, 15.5, 14.10, 13.13; MySQL 8.0.35, 8.0.28, 5.7.44; MariaDB 10.11.6, 10.6.16.
- Instance classes: db.t3.micro, db.t3.small, db.t3.medium, db.t3.large, db.t4g.micro, db.t4g.small, db.m5.large.
- Engine-aware runtime: selects image and port (5432 for postgres; 3306 for mysql/mariadb), sets POSTGRES_*, MYSQL_*, MARIADB_* env vars; postgres readiness check; short startup wait for MySQL/MariaDB.
- Defaults: parameter groups per family (e.g., default.postgres16, default.mysql8.0, default.mariadb10.11), engine-based default DB name (postgres or mysql), and port.
- Metadata fields: BackupRetentionPeriod (default 1), PreferredBackupWindow (default 03:00-04:00), LatestRestorableTime (set to created_at), OptionGroupName (optional), MultiAZ (boolean). Parsed on create, stored, rendered in responses, and copied to read replicas.
- Validation enforces supported engines/versions and instance classes; describe/orderable APIs list all versions and classes.
Tests
- Conformance updated to expect 7 instance classes per engine/version and multiple postgres versions.
- E2E expects 4 postgres versions.
- Orderable options tests cover 9 versions × 7 classes (63 combos).

^{Written for commit c506290. Summary will update on new commits.}

- Add PostgreSQL versions: 16.3, 15.5, 14.10, 13.13 - Add MySQL versions: 8.0.35, 8.0.28, 5.7.44 - Add MariaDB versions: 10.11.6, 10.6.16 - Update runtime to select Docker images based on engine/version - Handle engine-specific environment variables (POSTGRES_*, MYSQL_*, MARIADB_*) - Default ports: 5432 (postgres), 3306 (mysql/mariadb) - Default parameter groups for all engine families - Update validation to support all engines and versions - Update all tests to account for multiple engines

cubic-dev-ai

5 issues found across 4 files

_{You’re at about 87% of the monthly review limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="crates/fakecloud-rds/src/service.rs">

<violation number="1" location="crates/fakecloud-rds/src/service.rs:1010">
P1: Snapshot restore is still PostgreSQL-only, so MySQL/MariaDB restores will fail after starting the new engine-specific container.</violation>

<violation number="2" location="crates/fakecloud-rds/src/service.rs:1153">
P1: Read-replica creation is still wired to `pg_dump`/`psql`, so the new MySQL/MariaDB paths cannot replicate data.</violation>
</file>

<file name="crates/fakecloud-conformance/tests/rds.rs">

<violation number="1" location="crates/fakecloud-conformance/tests/rds.rs:21">
P2: These assertions are too permissive for `DescribeDBEngineVersions`: they don't verify that the response is fully filtered to PostgreSQL or that all expected PostgreSQL versions are returned.</violation>
</file>

<file name="crates/fakecloud-rds/src/runtime.rs">

<violation number="1" location="crates/fakecloud-rds/src/runtime.rs:77">
P1: MySQL and MariaDB containers are still looked up on port 5432, so the new engine paths cannot start successfully.</violation>

<violation number="2" location="crates/fakecloud-rds/src/runtime.rs:179">
P2: The new MySQL/MariaDB path returns success after a fixed 5-second sleep without checking that the database is actually ready.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-04-10T05:08:16Z

        let running = match runtime
            .ensure_postgres(
                &db_instance_identifier,
+                &source_instance.engine,


P1: Read-replica creation is still wired to pg_dump/psql, so the new MySQL/MariaDB paths cannot replicate data.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/fakecloud-rds/src/service.rs, line 1153: <comment>Read-replica creation is still wired to `pg_dump`/`psql`, so the new MySQL/MariaDB paths cannot replicate data.</comment> <file context> @@ -1110,6 +1150,8 @@ impl RdsService { let running = match runtime .ensure_postgres( &db_instance_identifier, + &source_instance.engine, + &source_instance.engine_version, &source_instance.master_username, </file context>

cubic-dev-ai · 2026-04-10T05:08:16Z

        let running = match runtime
            .ensure_postgres(
                &db_instance_identifier,
+                &snapshot.engine,


P1: Snapshot restore is still PostgreSQL-only, so MySQL/MariaDB restores will fail after starting the new engine-specific container.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/fakecloud-rds/src/service.rs, line 1010: <comment>Snapshot restore is still PostgreSQL-only, so MySQL/MariaDB restores will fail after starting the new engine-specific container.</comment> <file context> @@ -969,6 +1007,8 @@ impl RdsService { let running = match runtime .ensure_postgres( &db_instance_identifier, + &snapshot.engine, + &snapshot.engine_version, &snapshot.master_username, </file context>

cubic-dev-ai · 2026-04-10T05:08:16Z

@@ -54,29 +54,84 @@ impl RdsRuntime {
    pub async fn ensure_postgres(


P1: MySQL and MariaDB containers are still looked up on port 5432, so the new engine paths cannot start successfully.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/fakecloud-rds/src/runtime.rs, line 77: <comment>MySQL and MariaDB containers are still looked up on port 5432, so the new engine paths cannot start successfully.</comment> <file context> @@ -54,29 +54,84 @@ impl RdsRuntime { + ]; + (image, "5432", env_vars) + } + "mysql" => { + let major_version = if engine_version.starts_with("5.7") { + "5.7" </file context>

cubic-dev-ai · 2026-04-10T05:08:16Z

+    assert!(versions.len() >= 4);
+    assert!(versions.iter().any(|v| v.engine_version() == Some("16.3")));


P2: These assertions are too permissive for DescribeDBEngineVersions: they don't verify that the response is fully filtered to PostgreSQL or that all expected PostgreSQL versions are returned.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/fakecloud-conformance/tests/rds.rs, line 21: <comment>These assertions are too permissive for `DescribeDBEngineVersions`: they don't verify that the response is fully filtered to PostgreSQL or that all expected PostgreSQL versions are returned.</comment> <file context> @@ -17,10 +17,9 @@ async fn rds_describe_db_engine_versions() { - assert_eq!(versions[0].engine_version(), Some("16.3")); - assert_eq!(versions[0].db_parameter_group_family(), Some("postgres16")); + // Returns all postgres versions + assert!(versions.len() >= 4); + assert!(versions.iter().any(|v| v.engine_version() == Some("16.3"))); } </file context>

Suggested change

assert!(versions.len() >= 4);

assert!(versions.iter().any(|v| v.engine_version() == Some("16.3")));

let engine_versions: std::collections::BTreeSet<_> = versions

.iter()

.map(|v| (v.engine(), v.engine_version(), v.db_parameter_group_family()))

.collect();

assert_eq!(

engine_versions,

std::collections::BTreeSet::from([

(Some("postgres"), Some("13.13"), Some("postgres13")),

(Some("postgres"), Some("14.10"), Some("postgres14")),

(Some("postgres"), Some("15.5"), Some("postgres15")),

(Some("postgres"), Some("16.3"), Some("postgres16")),

])

);

cubic-dev-ai · 2026-04-10T05:08:16Z

+            }
+        } else {
+            // For MySQL/MariaDB, give it a moment to start
+            tokio::time::sleep(Duration::from_secs(5)).await;


P2: The new MySQL/MariaDB path returns success after a fixed 5-second sleep without checking that the database is actually ready.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/fakecloud-rds/src/runtime.rs, line 179: <comment>The new MySQL/MariaDB path returns success after a fixed 5-second sleep without checking that the database is actually ready.</comment> <file context> @@ -109,12 +164,19 @@ impl RdsRuntime { + } + } else { + // For MySQL/MariaDB, give it a moment to start + tokio::time::sleep(Duration::from_secs(5)).await; } </file context>

- Add db.t3.small, db.t3.medium, db.t3.large - Add db.t4g.micro, db.t4g.small - Add db.m5.large - All instance classes available for all engines - 63 total orderable options (9 versions × 7 classes)

cubic-dev-ai

1 issue found across 3 files (changes from recent commits).

_{You’re at about 87% of the monthly review limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="crates/fakecloud-rds/src/state.rs">

<violation number="1" location="crates/fakecloud-rds/src/state.rs:362">
P2: This adds a second source of truth for supported DB instance classes. Please share one constant/helper between `default_orderable_options()` and `validate_db_instance_class()` so the describe and create/modify APIs cannot drift apart.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-04-10T08:38:58Z

+        ("mariadb", "10.6.16", "general-public-license"),
+    ];
+
+    let instance_classes = vec![


P2: This adds a second source of truth for supported DB instance classes. Please share one constant/helper between default_orderable_options() and validate_db_instance_class() so the describe and create/modify APIs cannot drift apart.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/fakecloud-rds/src/state.rs, line 362: <comment>This adds a second source of truth for supported DB instance classes. Please share one constant/helper between `default_orderable_options()` and `validate_db_instance_class()` so the describe and create/modify APIs cannot drift apart.</comment> <file context> @@ -359,16 +359,28 @@ pub fn default_orderable_options() -> Vec<OrderableDbInstanceOption> { ("mariadb", "10.6.16", "general-public-license"), ]; + let instance_classes = vec![ + "db.t3.micro", + "db.t3.small", </file context>

Add metadata-only fields for Batches 7-10: - BackupRetentionPeriod (default 1 day) - PreferredBackupWindow (default 03:00-04:00) - LatestRestorableTime (set to created_at) - OptionGroupName (optional) - MultiAZ (boolean flag) Changes: - Parse new parameters in CreateDBInstance - Store fields in DbInstance struct - Render in XML responses - Copy from source for read replicas - Update all test fixtures These are metadata-only - no actual backup automation or multi-AZ standby provisioning implemented.

cubic-dev-ai

3 issues found across 3 files (changes from recent commits).

_{You’re at about 87% of the monthly review limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.}

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="crates/fakecloud-rds/src/state.rs">

<violation number="1" location="crates/fakecloud-rds/src/state.rs:39">
P2: Make `latest_restorable_time` optional. A mandatory timestamp forces backup-disabled instances (`BackupRetentionPeriod=0`) to look point-in-time restorable.</violation>
</file>

<file name="crates/fakecloud-rds/src/service.rs">

<violation number="1" location="crates/fakecloud-rds/src/service.rs:1082">
P1: Snapshot/replica paths are still PostgreSQL-only for MySQL/MariaDB instances.</violation>

<violation number="2" location="crates/fakecloud-rds/src/service.rs:2174">
P2: MySQL/MariaDB instance XML still reports a PostgreSQL license model.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-04-10T09:12:55Z

@@ -128,10 +128,49 @@ impl RdsService {
        let deletion_protection =


P1: Snapshot/replica paths are still PostgreSQL-only for MySQL/MariaDB instances.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/fakecloud-rds/src/service.rs, line 1082: <comment>Snapshot/replica paths are still PostgreSQL-only for MySQL/MariaDB instances.</comment> <file context> @@ -1065,6 +1079,11 @@ impl RdsService { read_replica_db_instance_identifiers: Vec::new(), vpc_security_group_ids, db_parameter_group_name: None, + backup_retention_period: 1, + preferred_backup_window: "03:00-04:00".to_string(), + latest_restorable_time: created_at, </file context>

cubic-dev-ai · 2026-04-10T09:12:55Z

    pub db_parameter_group_name: Option<String>,
+    pub backup_retention_period: i32,
+    pub preferred_backup_window: String,
+    pub latest_restorable_time: DateTime<Utc>,


P2: Make latest_restorable_time optional. A mandatory timestamp forces backup-disabled instances (BackupRetentionPeriod=0) to look point-in-time restorable.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/fakecloud-rds/src/state.rs, line 39: <comment>Make `latest_restorable_time` optional. A mandatory timestamp forces backup-disabled instances (`BackupRetentionPeriod=0`) to look point-in-time restorable.</comment> <file context> @@ -34,6 +34,11 @@ pub struct DbInstance { pub db_parameter_group_name: Option<String>, + pub backup_retention_period: i32, + pub preferred_backup_window: String, + pub latest_restorable_time: DateTime<Utc>, + pub option_group_name: Option<String>, + pub multi_az: bool, </file context>

cubic-dev-ai · 2026-04-10T09:12:55Z

@@ -128,10 +128,49 @@ impl RdsService {
        let deletion_protection =


P2: MySQL/MariaDB instance XML still reports a PostgreSQL license model.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At crates/fakecloud-rds/src/service.rs, line 2174: <comment>MySQL/MariaDB instance XML still reports a PostgreSQL license model.</comment> <file context> @@ -2147,6 +2171,19 @@ fn db_instance_xml(instance: &DbInstance, status_override: Option<&str>) -> Stri None => "<DBParameterGroups/>".to_string(), }; + let option_group_memberships_xml = match &instance.option_group_name { + Some(og_name) => format!( + "<OptionGroupMemberships>\ </file context>

…ersion

Add full MySQL/MariaDB support to RDS implementation: - Add mysql_async dependency for MySQL/MariaDB connection testing - Implement wait_for_mysql() with proper connection validation - Update lookup_port() to accept port parameter (5432 for postgres, 3306 for mysql/mariadb) - Update restart_container() to support all engine types - Replace sleep-based MySQL/MariaDB readiness with actual connection tests Addresses Cubic P1 issue from PR #220: MySQL/MariaDB features were incomplete (snapshot restore, read replicas, port lookup all PostgreSQL-only).

cubic-dev-ai Bot reviewed Apr 10, 2026

View reviewed changes

vieiralucas added 2 commits April 10, 2026 05:31

fix(rds): update E2E test for multiple postgres versions

96cc2af

feat(rds): add extended instance class support

d3f3bcf

- Add db.t3.small, db.t3.medium, db.t3.large - Add db.t4g.micro, db.t4g.small - Add db.m5.large - All instance classes available for all engines - 63 total orderable options (9 versions × 7 classes)

cubic-dev-ai Bot reviewed Apr 10, 2026

View reviewed changes

fix(rds): update conformance test for 7 instance classes per engine/v…

c506290

…ersion

vieiralucas merged commit fc1e8f4 into main Apr 10, 2026
22 checks passed

vieiralucas deleted the feat/rds-multiple-engines branch April 10, 2026 09:43

This was referenced Apr 10, 2026

feat(rds): complete MySQL/MariaDB support with proper readiness checks #228

Merged

fix(rds): add MySQL/MariaDB dump/restore, fix license model and metadata #276

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rds): add multi-engine support (PostgreSQL, MySQL, MariaDB)#220

feat(rds): add multi-engine support (PostgreSQL, MySQL, MariaDB)#220
vieiralucas merged 5 commits intomainfrom
feat/rds-multiple-engines

vieiralucas commented Apr 10, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		@@ -54,29 +54,84 @@ impl RdsRuntime {
		pub async fn ensure_postgres(

		assert!(versions.len() >= 4);
		assert!(versions.iter().any(\|v\| v.engine_version() == Some("16.3")));

-    assert!(versions.len() >= 4);
-    assert!(versions.iter().any(|v| v.engine_version() == Some("16.3")));
+    let engine_versions: std::collections::BTreeSet<_> = versions
+        .iter()
+        .map(|v| (v.engine(), v.engine_version(), v.db_parameter_group_family()))
+        .collect();
+    assert_eq!(
+        engine_versions,
+        std::collections::BTreeSet::from([
+            (Some("postgres"), Some("13.13"), Some("postgres13")),
+            (Some("postgres"), Some("14.10"), Some("postgres14")),
+            (Some("postgres"), Some("15.5"), Some("postgres15")),
+            (Some("postgres"), Some("16.3"), Some("postgres16")),
+        ])
+    );

		@@ -128,10 +128,49 @@ impl RdsService {
		let deletion_protection =

Conversation

vieiralucas commented Apr 10, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by cubic

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vieiralucas commented Apr 10, 2026 •

edited by cubic-dev-ai Bot

Loading

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading

cubic-dev-ai Bot Apr 10, 2026 •

edited

Loading