fix(rds): add MySQL/MariaDB dump/restore, fix license model and metadata#276
Merged
vieiralucas merged 2 commits intomainfrom Apr 12, 2026
Merged
fix(rds): add MySQL/MariaDB dump/restore, fix license model and metadata#276vieiralucas merged 2 commits intomainfrom
vieiralucas merged 2 commits intomainfrom
Conversation
… latest_restorable_time - Branch dump_database/restore_database by engine: mysqldump/mysql for MySQL/MariaDB, pg_dump/psql for PostgreSQL - Return correct license model per engine (general-public-license for MySQL/MariaDB) - Make latest_restorable_time optional — omit for instances with backup_retention_period=0 - Unify supported DB instance classes into single SUPPORTED_INSTANCE_CLASSES constant - Use engine-appropriate default DB name (mysql vs postgres)
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="crates/fakecloud-rds/src/service.rs">
<violation number="1" location="crates/fakecloud-rds/src/service.rs:1149">
P2: Set `latest_restorable_time` conditionally for read replicas so instances with `BackupRetentionPeriod=0` omit `LatestRestorableTime`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…based on source backup config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dump_database/restore_databaseby engine:mysqldump/mysqlfor MySQL/MariaDB,pg_dump/psqlfor PostgreSQL — read replicas and snapshot restores now work across all enginesgeneral-public-licensefor MySQL/MariaDB,postgresql-licensefor PostgreSQL)latest_restorable_timeoptional — omit XML element for instances withBackupRetentionPeriod=0SUPPORTED_INSTANCE_CLASSESconstant to prevent driftmysqlvspostgres)Addresses unresolved Cubic findings from PR #220.
Test plan
cargo clippy --workspace --all-targets -- -D warningspassesSummary by cubic
Adds engine-aware dump/restore for RDS containers and fixes engine-specific metadata. Read replicas and snapshot restores now work for MySQL/MariaDB and PostgreSQL.
New Features
mysqldump/mysqlvspg_dump/psql).mysqlvspostgres).Bug Fixes
general-public-licensefor MySQL/MariaDB,postgresql-licensefor PostgreSQL).latest_restorable_timeis optional; omit XML whenBackupRetentionPeriod=0, and set it for read replicas based on the source instance’s backup config.SUPPORTED_INSTANCE_CLASSESas a single source of truth.Written for commit f2a1a91. Summary will update on new commits.