fix(ec2): persist VpnConnection StaticRoutesOnly and VpnGateway AmazonSideAsn/AvailabilityZone - #2462
Merged
Merged
Conversation
…nSideAsn/AvailabilityZone Cycle-8 bug-hunt EC2 write-read-loss round 2 (part 2): E2-4 - CreateVpnConnection dropped Options.StaticRoutesOnly; vpn_conn_xml hardcoded <staticRoutesOnly>false</staticRoutesOnly>. Added the field, parse Options.StaticRoutesOnly, render it. aws_vpn_connection (ForceNew) with static_routes_only=true now converges. E2-5 - CreateVpnGateway dropped AmazonSideAsn (hardcoded 64512 in the render) and AvailabilityZone (never emitted). Added both fields, parse + render (AZ only when set). aws_vpn_gateway (ForceNew) round-trips a custom ASN/AZ. New state fields are #[serde(default)] so existing snapshots load. Remaining EC2 round-2 (documented in the cycle-8 report): RequestSpotInstances options+launch spec (E2-2, HIGH) and GetLaunchTemplateData derive-from-instance (E2-6). No new API surface -> no SDK/doc change. Tests: VpnConnection static-routes-only + VpnGateway asn/az round-trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cycle-8 bug-hunt EC2 write-read-loss round 2 (part 2):
CreateVpnConnectiondroppedOptions.StaticRoutesOnly;vpn_conn_xmlhardcoded<staticRoutesOnly>false</staticRoutesOnly>. Added the field + parse + render.aws_vpn_connection(ForceNew) withstatic_routes_only = truenow converges.CreateVpnGatewaydroppedAmazonSideAsn(hardcoded 64512 in the render) andAvailabilityZone(never emitted). Added both fields + parse + render (AZ only when set).aws_vpn_gateway(ForceNew) round-trips a custom ASN/AZ.New state fields are
#[serde(default)]so existing snapshots load.Remaining EC2 round-2 (documented in the cycle-8 report): RequestSpotInstances options+launch spec (E2-2, HIGH) and GetLaunchTemplateData derive-from-instance (E2-6).
Test plan
cargo nextest run -p fakecloud-ec2: 213 passed.--all-targets -D warnings+ fmt clean.Summary by cubic
Fixes EC2 VPN write-read drift by persisting
StaticRoutesOnlyon VPN connections andAmazonSideAsn/AvailabilityZoneon VPN gateways. Describe responses now reflect requested values, avoiding Terraform drift on non-defaults.CreateVpnConnection: parse and storeOptions.StaticRoutesOnly; render inDescribeVpnConnections.CreateVpnGateway: parse and storeAmazonSideAsnandAvailabilityZone; render inDescribeVpnGateways(AZ only when set).Written for commit e4daccd. Summary will update on new commits.