[pull] master from mozilla:master#1639
Merged
pull[bot] merged 3 commits intofakegit:masterfrom Apr 20, 2021
Merged
Conversation
…r listed reviewers (#16983) Flip the logic around: if the user doesn't have unlisted permission, instead of filtering to only show activities linked to a version on listed channel, exclude those on unlisted channel. That makes activities not linked to a particular version, like force disable/enable, visible for those users. Same idea applied to the review link URL: instead of defaulting to unlisted and changing that if the activity is linked to a listed version, default to listed and only link to unlisted review page if the activity is linked to an unlisted version.
…16976) Co-authored-by: kolverar <kevincristia@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )