[pull] master from GNOME:master#2320
Merged
pull[bot] merged 8 commits intofakegit:masterfrom Apr 7, 2024
Merged
Conversation
After the referenced commit, the title bar became to tall. This was due to lack of testing. Now, both title bar and header bar are 36px.
Extract pseudo class string-port methods to separate file. No functional changes intended. Style changes not complete: anticipate further bug fixes and styling.
Fix #11040 and #9495 bugs with unicode in string-ports Fix other unreported bugs with allocations and garbage collection of string-ports. Obsolete open-input-output-string, a string port of kind input-ouput is no longer supported and the function actually opens a string-port of kind input which cannot be written. Comments and Gimp style in the original TinyScheme code, now in string-port.c Revise tests of string-port. Update TinyScheme README: Discuss more thoroughly the ancestry, and changes from upstream.
Redefine call-with-output-string etc. in the test script: test9.scm Other fixes to the test script. Improve logging of no memory condition for string-ports Fix bug freeing ports that have been closed. When ports are closed, string-port code was treating them as string-ports.
Add canonical/idiomatic functions call-with-output-string, call-with-input-string, any->string to the library init.scm. Since they are useful, especially in test scripts and frameworks. Remove their definitions from test scripts and test frameworks. Also comment out failing test in test script string-escape.scm.
It is broken and throws critical, see #10596. Expedient to hide it instead of fixing it, to not block 3.0rc1. As discussed in #10652, a user can simply restart GIMP instead. "Refresh Scripts" is a poor design, a bandaid. There are plans for better alternatives to install/remove scripts. The MR for #10652 shows the reason it throws critical, and could fix it, but completing the MR requires time we don't have. Note the MR is not on these files, but on core plugin machinery. The change is to extract functions to a separate file, and still build them, but not call them or link them. They also are not translated while not being called. Eventually, the extracted files can be deleted (or restored when they work.) There is other related cruft that needs deletion in scheme-wrapper.c.
Resolves #11244 GtkRadioButtons can also have the .text-button CSS class set. This class was overwriting the radiobutton background color, making it appear dark and box-like. This adds a specific radiobutton.text-button definition to ensure the background color is consistent (as we had to do with checkbutton.text-button)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )