[pull] master from GNOME:master#2437
Merged
pull[bot] merged 10 commits intofakegit:masterfrom Oct 9, 2024
Merged
Conversation
Previously filters were cropped to the layer size in the "crop_before" node. This was fine when we had destructive-only filters, but now that we can multiple active layers, this causes new layers to crop the prior ones if they're larger than the layer (e.g. If gegl:drop-shadow goes out of the layer boundaries) This patch sets the crop_before to the current sizes, then searches the filter stack to see if there's a filter that needs a larger width or height (or if it needs a smaller x or y values), then sets the crop to that size. This crop update is also run when a filter is raised or lowered.
* Do not force-clip effects with a mask. Otherwise when adding a filter, it initially renders fine (and can cross its input extents), but once applied, it's suddenly clipped. That's not what we want. * Fix gimp_filter_stack_get_bounding_box() computation. * Fix the crop_before area when there was a selection. We have in fact to start at 0×0 on input and only use width×height dimensions.
Code that updates the main dialogue preview and the editing dialogue preview were conflicting with each other, setting various strings to NULL. This patch turns off the main dialogue preview updating code when the edit dialogue is open, to prevent this overwriting behavior.
Gradient Flare still used gimp_dialog_run () for its GimpProcedureDialog, so the Reset button was treated as Cancel. This fixes it so that it's usable.
…ndle This eliminates the CRITICAL, which was harmless anyway. As discussed in the issue, there are more issues: 1. The "shift-start" action is not documented in the user manual. 2. The "shift-start" action quietly does nothing in the case it has nothing to do. Better GUI would be to disable the menu item in that case. 3. The "shift-start" action is non-intuitive, even bizarre. It could probably be eliminated. I myself don't understand the use case, and confused it for Path>Reverse. An alternative fix is to disable the menu item when a handle is the operand. This fix is better because it gives the user more places to RMB a context menu, and the context menu mutates less. Probably needs backport to 2.10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )