Skip to content

Mimeparse should gracefully handle an invalid mime type of the form "text/extra/part"#14

Merged
dbtsai merged 1 commit intofalconry:masterfrom
wojcikstefan:fix-extra-slash
Apr 21, 2016
Merged

Mimeparse should gracefully handle an invalid mime type of the form "text/extra/part"#14
dbtsai merged 1 commit intofalconry:masterfrom
wojcikstefan:fix-extra-slash

Conversation

@wojcikstefan
Copy link
Copy Markdown
Collaborator

Hi @dbtsai. See the added test data to understand the use case. Could you merge + make a release?

@dbtsai dbtsai merged commit 40e4417 into falconry:master Apr 21, 2016
@dbtsai
Copy link
Copy Markdown
Collaborator

dbtsai commented Apr 21, 2016

Thanks.

@wojcikstefan
Copy link
Copy Markdown
Collaborator Author

Thanks for merging @dbtsai. Let me know if you could make a new PyPI release :)

@dbtsai
Copy link
Copy Markdown
Collaborator

dbtsai commented Apr 21, 2016

@wojcikstefan Since I'm not actively on this project anymore, how about I add you as new maintainer?

@wojcikstefan
Copy link
Copy Markdown
Collaborator Author

I'd be happy/honored to share the responsibility :)

@dbtsai
Copy link
Copy Markdown
Collaborator

dbtsai commented Apr 22, 2016

@wojcikstefan Do you have the PyPI account?

@wojcikstefan
Copy link
Copy Markdown
Collaborator Author

@dbtsai Yup, my username on PyPI is wojcikstefan (same as GitHub).

@dbtsai
Copy link
Copy Markdown
Collaborator

dbtsai commented Apr 25, 2016

@wojcikstefan I just added you as owner. Feel free to make a new release. Thanks.

@wojcikstefan
Copy link
Copy Markdown
Collaborator Author

@dbtsai I tried to push a new commit to master (to bump __version__ to 1.5.2), but got:

(venv)[python-mimeparse] g pus
ERROR: Permission to dbtsai/python-mimeparse.git denied to wojcikstefan.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@dbtsai
Copy link
Copy Markdown
Collaborator

dbtsai commented Apr 26, 2016

@wojcikstefan I add you permission this repo. Please try it again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants