Skip to content

Mimeparse should gracefully handle an invalid mime type of the form "text/extra/part" #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbtsai merged 1 commit into from
Apr 21, 2016
Merged

Mimeparse should gracefully handle an invalid mime type of the form "text/extra/part" #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mimeparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,11 @@ def parse_mime_type(mime_type):
if full_type == '*':
full_type = '*/*'

if '/' not in full_type:
type_parts = full_type.split('/') if '/' in full_type else None
if not type_parts or len(type_parts) > 2:
raise MimeTypeParseException("Can't parse type \"{}\"".format(full_type))

(type, subtype) = full_type.split('/')
(type, subtype) = type_parts

return (type.strip(), subtype.strip(), params)

Expand Down
3 changes: 2 additions & 1 deletion testdata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"parse_mime_type": [
["application/xhtml;q=0.5", ["application", "xhtml", {"q": "0.5"}]],
["application/xhtml;q=0.5;ver=1.2", ["application", "xhtml", {"q": "0.5", "ver": "1.2"}]],
["text", null]
["text", null],
["text/something/invalid", null]
]
}